Once a property from the foreign repository is used in the statement, its ID is displayed instead of the label, and "Deleted property" note is added. See screen cap below.
Formatter's logic should be adjusted to account for foreign entities.
Description
Description
Details
Details
Related Changes in Gerrit:
Event Timeline
Comment Actions
After some code-spelunking with @WMDE-leszek, we found that the issue here is two-fold:
- the EntityIdHtmlLinkFormatter needs to get the correct LabelDescriptionLookup - one that can handle multiple repositories. FormatterLabelDescriptionLookupFactory is responsible for providing this instance. In an EntityView, this will be based on an EntityInfoTermLookup, which leads to the problem of creating an EntityInfoBuilder that can handle federation. I filed T157363 for this.
- EntityIdHtmlLinkFormatter needs to correctly handle the fact that a) TitleLookup::getTitleForId may return null, and b) Title::exists() returns false for interwiki titles. So, the existance check should be skipped if the title is not local, and getTitleForId returning null should be treated as if the entity was missing (as if exists() returned false).
Comment Actions
Change 336240 had a related patch set uploaded (by WMDE-leszek):
EntityIdHtmlLinkFormatter: do not check existence of non-local titles
Comment Actions
Change 336240 merged by jenkins-bot:
EntityIdHtmlLinkFormatter: do not check existence of non-local titles