Page MenuHomePhabricator

$wgReadOnly not being parsed properly on Special:CreateAccount
Closed, ResolvedPublic

Description

[[https://www.mediawiki.org/wiki/Manual:$wgReadOnly|$wgReadOnly]] can be set to a string to lock the database against write actions. This string can contain basic HTML that's allowed in wikitext, and most special pages -- including, but definitely not limited to Special:SpecialPages, Special:Upload, etc. -- parse the HTML correctly. Special:CreateAccount does not appear to, as shown by this screenshot:

CreateAccount-message-parsing-bug.png (877×1 px, 96 KB)

From what I can see, checkPermissions() in /includes/specials/SpecialCreateAccount.php calls AuthManager::singleton()->checkAccountCreatePermissions( $user ) and if (and in this case, when) the returned Status is not good, it throws an ErrorPageError with the i18n msg createacct-error as the error title and $status->getMessage() as the actual error message, but I'm not sure why it isn't getting parsed correctly.

Event Timeline

Change 372763 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/core@master] AuthManager: Consistent behavior of read-only reason on Special:CreateAccount

https://gerrit.wikimedia.org/r/372763

Change 372763 merged by jenkins-bot:
[mediawiki/core@master] Consistent behavior of read-only reason

https://gerrit.wikimedia.org/r/372763