Page MenuHomePhabricator
Create Task
Maniphest T157075

Cleanup feature flags for footer work
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

We pushed the footer in Sprint 83.
Now it's sprint 91, we are long overdue removing the code needed to support the old footer so let's remove that code.

Acceptance criteria

  • All traces of MinervaUseFooterV2 removed from repository
  • Remove i18n, resources from old footer
  • Footer works in desktop and mobile versions of Minerva
  • Merge skins.minerva.footerV2.styles module into skins.minerva.base.styles - https://gerrit.wikimedia.org/r/#/c/335699/
  • Remove usages of MinervaUseFooterV2 from mediawiki-config. This can be done now as the default value in MobileFrontend master is true. Although for completeness probably best to do after it is removed from MobileFrontend - https://gerrit.wikimedia.org/r/336664 wgMinervaUseFooterV2

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
wgMinervaUseFooterV2 config flag no longer necessaryJdlrobsonoperations/mediawiki-configmaster+0 -3
Hygiene: Merge footer v2 style module into default style moduleJdlrobsonmediawiki/extensions/MobileFrontendmaster+10 -25
Remove old footer remnant for mobile/desktop toggleJdlrobsonmediawiki/extensions/MobileFrontendmaster+0 -8
Hygiene: Remove MinervaUseFooterV2Jdlrobsonmediawiki/extensions/MobileFrontendmaster+39 -195
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Feb 2 2017, 9:15 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptFeb 2 2017, 9:15 PM
Jdlrobson updated the task description. (Show Details)Feb 2 2017, 9:16 PM
gerritbot added a comment.Feb 2 2017, 9:17 PM

Change 335080 had a related patch set uploaded (by Jdlrobson):
Hygiene: Remove MinervaUseFooterV2

https://gerrit.wikimedia.org/r/335080

gerritbot added a project: Patch-For-Review.Feb 2 2017, 9:17 PM
gerritbot added a comment.Feb 2 2017, 9:19 PM

Change 335699 had a related patch set uploaded (by Jdlrobson):
Hygiene: Merge footer v2 style module into default style module

https://gerrit.wikimedia.org/r/335699

Jdlrobson added a project: Wikimedia-Site-requests.Feb 2 2017, 9:20 PM
Jdlrobson updated the task description. (Show Details)
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptFeb 2 2017, 9:20 PM
Jdlrobson updated the task description. (Show Details)Feb 2 2017, 9:21 PM
ovasileva added projects: Reading-Web-Sprint-91-🐔🍔, Unplanned-Sprint-Work.Feb 3 2017, 1:43 PM

pulling this in then

Jdlrobson moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-91-🐔🍔 board.Feb 3 2017, 6:27 PM
ovasileva moved this task from Incoming to 2016-17 Q3 on the Web-Team-Backlog-Archived board.Feb 3 2017, 6:54 PM
Jdlrobson claimed this task.Feb 3 2017, 9:50 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Reading-Web-Sprint-91-🐔🍔 board.
phuedx added a comment.Feb 6 2017, 12:00 PM

@Jdlrobson: Could you add a provisional estimate for this work?

Jdlrobson set the point value for this task to 2.Feb 6 2017, 7:21 PM

https://gerrit.wikimedia.org/r/#/c/335080 currently has 2 +1s and there are 2 non-essential follow ups https://gerrit.wikimedia.org/r/335699 and https://gerrit.wikimedia.org/r/336239

gerritbot added a comment.Feb 6 2017, 9:41 PM

Change 335080 merged by jenkins-bot:
Hygiene: Remove MinervaUseFooterV2

https://gerrit.wikimedia.org/r/335080

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)).Feb 6 2017, 10:00 PM
gerritbot added a comment.Feb 6 2017, 10:49 PM

Change 336334 had a related patch set uploaded (by Jdlrobson):
Remove old footer remnant for mobile/desktop toggle

https://gerrit.wikimedia.org/r/336334

Jdlrobson added a comment.Feb 7 2017, 12:31 AM

A fair chunk of the work is done, but there are several small follow-ups:

phuedx added a comment.Feb 7 2017, 10:00 AM

I've -1'd rEMFRa8b8c83f5d15: Remove old footer remnant for mobile/desktop toggle. BTW I found that ZeroBanner was referencing 'mobile-switcher' by searching for it across all of our projects on GitHub.

phuedx added a comment.Feb 7 2017, 10:51 AM

I've -1'd rEMFRb8fd43a8f7d6: Hygiene: Merge footer v2 style module into default style module for your attention.

phuedx moved this task from Needs Code Review to Needs More Work on the Reading-Web-Sprint-91-🐔🍔 board.Feb 7 2017, 11:44 AM
Jdlrobson moved this task from Needs More Work to Doing on the Reading-Web-Sprint-91-🐔🍔 board.Feb 7 2017, 5:53 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Reading-Web-Sprint-91-🐔🍔 board.Feb 7 2017, 10:15 PM
Jdlrobson added a comment.Feb 7 2017, 10:36 PM

1KHBPmEOkv0B2.gif (215×146 px, 183 KB)

https://gerrit.wikimedia.org/r/336334 now depends on the Zero change https://gerrit.wikimedia.org/r/#/c/336546/
https://gerrit.wikimedia.org/r/335699 has been amended.

gerritbot added a comment.Feb 8 2017, 6:35 PM

Change 336334 had a related patch set uploaded (by Phuedx):
Remove old footer remnant for mobile/desktop toggle

https://gerrit.wikimedia.org/r/336334

gerritbot added a comment.Feb 8 2017, 7:06 PM

Change 336664 had a related patch set uploaded (by Jdlrobson):
wgMinervaUseFooterV2 config flag no longer necessary

https://gerrit.wikimedia.org/r/336664

Jdlrobson updated the task description. (Show Details)Feb 8 2017, 7:11 PM
This comment was removed by Jdlrobson.
gerritbot added a comment.Feb 8 2017, 7:13 PM

Change 336334 merged by jenkins-bot:
Remove old footer remnant for mobile/desktop toggle

https://gerrit.wikimedia.org/r/336334

Jdlrobson added a comment.Feb 8 2017, 7:19 PM

https://gerrit.wikimedia.org/r/#/c/335699/ remains!

Jdlrobson updated the task description. (Show Details)Feb 8 2017, 7:26 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)).Feb 8 2017, 8:00 PM
gerritbot added a comment.Feb 8 2017, 10:01 PM

Change 335699 merged by jenkins-bot:
Hygiene: Merge footer v2 style module into default style module

https://gerrit.wikimedia.org/r/335699

Jdlrobson moved this task from Needs Code Review to Blocked Externally on the Reading-Web-Sprint-91-🐔🍔 board.Feb 8 2017, 10:28 PM
Jdlrobson updated the task description. (Show Details)

Blocked as https://gerrit.wikimedia.org/r/336664 can only be deployed tomorrow and T153494 prevents the footer working 100% in desktop.

Jdlrobson added a parent task: T153494: PHP warnings related to footer V2 when run Minerva in desktop mode.Feb 8 2017, 10:29 PM
Jdlrobson moved this task from Blocked Externally to Needs Code Review on the Reading-Web-Sprint-91-🐔🍔 board.Feb 8 2017, 11:43 PM

I am wrong. Since this defaults to true anyway in MobileFrontend this is not a problem and can be swatted immediately.

gerritbot added a comment.Feb 9 2017, 12:16 AM

Change 336664 merged by jenkins-bot:
wgMinervaUseFooterV2 config flag no longer necessary

https://gerrit.wikimedia.org/r/336664

Stashbot added a comment.Feb 9 2017, 12:20 AM

Mentioned in SAL (#wikimedia-operations) [2017-02-09T00:20:54Z] <dereckson@tin> Synchronized wmf-config/InitialiseSettings.php: Prune wgMinervaUseFooterV2 (T157075) (duration: 00m 41s)

Jdlrobson updated the task description. (Show Details)Feb 9 2017, 12:26 AM
Jdlrobson removed a project: Patch-For-Review.
Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-91-🐔🍔 board.

The footer works in desktop and mobile but due to T153494 there is warnings. I think we should sign this task off as complete though even though that is the case as that problem is already tracked elsewhere.

phuedx reassigned this task from Jdlrobson to • bmansurov.Feb 9 2017, 6:46 AM
• bmansurov removed • bmansurov as the assignee of this task.Feb 9 2017, 9:13 PM
• bmansurov moved this task from Ready for Signoff to Needs More Work on the Reading-Web-Sprint-91-🐔🍔 board.
• bmansurov subscribed.

These points need work:

  • The message "mobile-frontend-footer-contact" doesn't seem to be used anywhere anymore.
Jdlrobson added a comment.Feb 9 2017, 9:27 PM
In T157075#3014754, @bmansurov wrote:

These points need work:

https://gerrit.wikimedia.org/r/336897

  • The message "mobile-frontend-footer-contact" doesn't seem to be used anywhere anymore.

Wow that's super old. We haven't used that in footer v1 for some time! I see it has not been needed since Ic50e87 (Oct 2012!! New record!) :)
I'm going to see what else is in there that neednt be.

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Reading-Web-Sprint-91-🐔🍔 board.Feb 9 2017, 9:27 PM
• bmansurov moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-91-🐔🍔 board.Feb 9 2017, 9:29 PM

OK, I think the point about the old message can be tackled separately. I've +2'ed the patch.

• bmansurov closed this task as Resolved.Feb 9 2017, 9:30 PM

The following acceptance criterion is being tackled in T153494:

  • Footer works in desktop and mobile versions of Minerva
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits