Merged, pending to be applied: T89737
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Reedy | T157227 MediaWiki DB tables with columns which references other columns but have different type (tracking) | |||
| Resolved | Reedy | T146570 Give user_properties a primary key | |||
| Resolved | Reedy | T172514 Add new PKs to tables.sql (mysql and sqlite) | |||
| Duplicate | None | T163911 Make user_newtalk.user_id unsigned in WMF production | |||
| Resolved | • Marostegui | T89737 Make several mediawiki table fields unsigned ints on wmf databases |
Change 350437 had a related patch set uploaded (by Reedy):
[mediawiki/core@master] [WIP] Making numerous fields unsigned to match their target referenced column
Apart from we don't really care about the others other than mysql/sqlite...
None of sqlite, pgsql or oracle have an unsigned type. The first has nothing at all, the second require constraints/domains to make it work
Changing this in mysql on referencing tables adds no more difference than is already there; the root user_id is not unsigned on any of the other DBMS
Ready now, I've +1'ed it. Waiting for your final approval to merge it (or feel free to +2 yourself).
Change 350437 merged by jenkins-bot:
[mediawiki/core@master] Making numerous fields unsigned to match their target referenced column
@Marostegui I think with T89737 this is fully resolved now? Or is there something pending on Mediawiki CC @Reedy
From the databases point of view it is all done (I just did a quick check to confirm)
This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!
For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)
Change 618637 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Make ct_rc_id unsigned
Change 618568 had a related patch set uploaded (by Reedy; owner: Ladsgroup):
[mediawiki/core@REL1_35] Make ct_rc_id unsigned
Change 618568 abandoned by Reedy:
[mediawiki/core@REL1_35] Make ct_rc_id unsigned
Reason:
I am going to resolve it based on: T157227#4897989
If there is something else broken, it can be filed on its own ticket.