Possible dup of: T145909

Potentially same fix (?) but this bug is different since it is specific to when the user is offline; and unlike T145909 nothing happens no matter the speed or number of times Random is tapped.

@RHo

• Why don't we want the user to save or share the random article?
• When the user taps "Another random article", do you mean that a new random article will be loaded in-place in the same card? (in which case, what should be the status indication while it's fetching the new title?) Or do you mean that a new random article will be opened in the page browsing activity? In which case, can we postpone this until we have the full re-roll functionality built into the page browsing activity?

hey @Dbrant

• Having the save and share random makes for a random article with a couple too many action items which looks somewhat cluttered, and moreover leads to a dead end with the random article, since it just remains there saved without any way load a new random article (which would be achieved by tapping to read it or tapping 'another random article'.
• 'Another random article' opens another random article in the article tabs (page browsing activity) – We could postpone until the full Random re-roll is implemented, but then we have the issue of not allowing the user a clear way to load another Random article besides tapping on the article (so all the more reason I would remove share and save).

@Dbrant – perhaps we are getting far away from the original intent of the task to fix Random as it is now not working properly on offline mode by half introducing a revamp of Random. Rather than revising the random card halfway, it would be clearer and more impactful to be introduced as one complete feature.

I propose reverting this ticket back to fixing the bug so that when the user is offline, tapping on the Random tile (as it looks currently) opens up the article tab with an 'Article not loaded' message.

{F5760820}

Per meeting discussion, I created a new task for improving the random T158788 and reverting this task description to fix the bug on Random when offline.

@RHo Thanks! Could you provide the vector asset for the graphic in the above screenshot?

sure thing – here's the svg, which should import fine into Studio:

Change 339632 had a related patch set uploaded (by Dbrant):
Make Random card pull from reading lists when offline.

https://gerrit.wikimedia.org/r/339632

Change 339632 merged by jenkins-bot:
Make Random card pull from reading lists when offline.

https://gerrit.wikimedia.org/r/339632

hi @Dbrant
Incorrect "Unknown error" message being shown when tapping on Randon whilst offline and there are no saved articles to open.
open to view animated gif:

Change 346987 had a related patch set uploaded (by Dbrant):
[apps/android/wikipedia@master] Improve message shown by Random card when offline.

https://gerrit.wikimedia.org/r/346987

Change 346987 merged by jenkins-bot:
[apps/android/wikipedia@master] Improve message shown by Random card when offline.

https://gerrit.wikimedia.org/r/346987

hi @Dbrant - can we just add a "RETRY" action on the snackbar and then will be fine to head QA.

Screenshot from:
Device = Pixel
Version = 2.5.195-alpha-2017-05-09

Test steps

1. Open an article in the app and save it to a reading list
2. Go offline
3. Tap on the Random card in the Explore feed [Expected: the random article loaded will pull from the article saved to the list and available offline]
4. Delete reading list and all articles available offline
5. Tap on the Random card again [Expected: snackbar advising user 'Cannot connect to internet' with 'RETRY' action]

@RHo Are we totally sure that the Retry action is necessary here? If the user wants to retry a random page, they can just tap the Random card again (the card will still be in view, by definition). And also, if the user has no internet connection, which is really the only reason for this message to appear, then the Retry action is highly unlikely to have any effect.

@Dbrant – I think it's good practice to standardize the action to always appear for the 'you are offline' snackbar. It also means if and when we change the random card later (for example the proposal to show an initial random article within the card), this can still apply.

Change 360649 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Add Retry action when fetching random article fails.

https://gerrit.wikimedia.org/r/360649

Change 360649 merged by jenkins-bot:
[apps/android/wikipedia@master] Add Retry action when fetching random article fails.

https://gerrit.wikimedia.org/r/360649

Hi @Dbrant – thanks for adding the snackbar and retry action, but can we update the message to "Cannot connect to the internet" or something less tech-jargony?

Thanks!

Change 364216 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Simplify error message upon failure to fetch random article.

https://gerrit.wikimedia.org/r/364216

Change 364216 merged by jenkins-bot:
[apps/android/wikipedia@master] Simplify error message upon failure to fetch random article.

https://gerrit.wikimedia.org/r/364216

LGTM

Tested on Nexus (Android 6.0.1), Wikipedia version 2.6.198-alpha-2017-07-18.

Testing on Samsung-SM-JI20A Galaxy Express 3 (Android 6.0.1) and Wikipedia version 2.6.198-alpha-2017-07-18,
I think that is the version, I am getting a crash when tapping Settings that needs a bug filed for it separately