As of 6aaba9f1 Wikibase no longer uses a single PrefetchingWikiPageEntityMetaDataAccessor instance, totally breaking the prefetching. This leads to sever slowdowns!
Description
Description
Details
Details
Customize query in gerrit
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 336264 had a related patch set uploaded (by Hoo man):
Revert "Allow optional usage of Client's data retrieval services in the Repo component"
Comment Actions
If I see right Api\GetEntities is getting the other instance than the entity revision lookups used by WikibaseRepo (via DispatchingEntityRevisionLookup) are using. This is indeed wrong. I am going to try fixing this.
Comment Actions
@WMDE-leszek Thanks. The dumpers are also very important here… if you can't find a viable solution for backport, please consider my revert.
Comment Actions
And dumpers yes, I didn't think they might be an issue too but they're probably even more important in this regard.
Comment Actions
Change 336387 had a related patch set uploaded (by WMDE-leszek):
Provide EntityPrefetcher in EntityDataRetrievalServiceFactory
Comment Actions
Change 336387 merged by jenkins-bot:
Provide EntityPrefetcher in EntityDataRetrievalServiceFactory
Comment Actions
Manually verified that the dumpers use proper prefetching again.
We probably want to backport this.
Comment Actions
Change 336452 had a related patch set uploaded (by Daniel Kinzler):
Revert "Allow optional usage of Client's data retrieval services in the Repo component"
Comment Actions
Change 336452 merged by jenkins-bot:
Revert "Allow optional usage of Client's data retrieval services in the Repo component"
Comment Actions
Change 336264 abandoned by Hoo man:
Revert "Allow optional usage of Client's data retrieval services in the Repo component"
Reason:
No longer relevant.
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2017-02-08T15:15:26Z] <hoo@tin> Synchronized php-1.29.0-wmf.11/extensions/Wikidata: Wikibase uses multiple EntityPrefetchers (T157380) (duration: 02m 11s)
Comment Actions
Time to dump testwikidatawiki went from 1m21.433s to 0m34.786s with the prefetcher fix.
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2017-02-08T15:20:56Z] <hoo@tin> Synchronized php-1.29.0-wmf.10/extensions/Wikidata: Wikibase uses multiple EntityPrefetchers (T157380) (duration: 02m 07s)