Page MenuHomePhabricator
Create Task
Maniphest T157406

VisualEditor eats leading spaces on paste
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce: paste

*
    *
*

into the new wikitext editor. The space characters on the second line will disappear. This is true even for raw paste (ctrl-shift-v).

Tested on Chrome 55 / Ubuntu 16.04.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (121100d74)mediawiki/extensions/VisualEditormaster+1 -1
Fix definition of HTML whitespace in converterVisualEditor/VisualEditormaster+34 -10
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Feb 7 2017, 2:35 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 7 2017, 2:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr updated the task description. (Show Details)Feb 7 2017, 2:44 AM
Schnark subscribed.Feb 7 2017, 10:13 AM

In Firefox the spaces are almost preserved, only converted to non-breaking ones (which is reported in some other task, I can't find it at the moment).

gerritbot subscribed.Feb 7 2017, 5:56 PM

Change 336445 had a related patch set uploaded (by Esanders):
Fix definition of HTML whitespace in converter

https://gerrit.wikimedia.org/r/336445

gerritbot added a project: Patch-For-Review.Feb 7 2017, 5:56 PM
Esanders renamed this task from New wikitext editor eats leading spaces on paste to VisualEditor eats leading spaces on paste.Feb 7 2017, 5:56 PM
Esanders removed a project: VisualEditor-MediaWiki-2017WikitextEditor.
Esanders subscribed.

This is actually not specific to NWE, it was a bug in the converter.

gerritbot added a comment.Feb 7 2017, 6:27 PM

Change 336445 merged by jenkins-bot:
Fix definition of HTML whitespace in converter

https://gerrit.wikimedia.org/r/336445

gerritbot added a comment.Feb 7 2017, 6:28 PM

Change 336450 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (121100d74)

https://gerrit.wikimedia.org/r/336450

Jdforrester-WMF closed this task as Resolved.Feb 7 2017, 6:57 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF edited projects, added VisualEditor-CopyPaste; removed Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
gerritbot added a comment.Feb 7 2017, 7:18 PM

Change 336450 merged by jenkins-bot:
Update VE core submodule to master (121100d74)

https://gerrit.wikimedia.org/r/336450

Jdforrester-WMF added a project: MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)).Feb 7 2017, 7:39 PM
Tanveer07 added a project: Verified.Feb 14 2017, 10:54 PM
Ryasmeen added a project: Verified-in-Phase0.Feb 15 2017, 8:36 PM
Ryasmeen added a project: Verified-in-Phase2.Feb 16 2017, 10:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL