@demon does this need a new repo for scap to clone from?

Also how will this work as doesn't scap only deploy to one location? Since how will the init and systemd scripts be able to be added?

Change 356482 had a related patch set uploaded (by Chad; owner: Chad):
[operations/software/gerrit@master] Configuring git-fat to work with Archiva

https://gerrit.wikimedia.org/r/356482

Change 356484 had a related patch set uploaded (by Chad; owner: Chad):
[operations/software/gerrit@master] Adding scap3 config

https://gerrit.wikimedia.org/r/356484

Change 356488 had a related patch set uploaded (by Chad; owner: Chad):
[operations/software/gerrit@master] Add core core plugins @ 2.13.8

https://gerrit.wikimedia.org/r/356488

@demon Guess you are working on that? (Since patches got uploaded, but you were removed as asignee some time ago)

Change 356482 merged by Chad:
[operations/software/gerrit@master] Configuring git-fat to work with Archiva

https://gerrit.wikimedia.org/r/356482

Change 356488 merged by Chad:
[operations/software/gerrit@master] Add core core plugins @ 2.13.8

https://gerrit.wikimedia.org/r/356488

Change 356484 merged by Chad:
[operations/software/gerrit@master] Adding scap3 config

https://gerrit.wikimedia.org/r/356484

What about having a script on the client that moves the file into place after scapping. Ie like we do with services?

In T157414#3402741, @Paladox wrote:

What about having a script on the client that moves the file into place after scapping. Ie like we do with services?

I don't need to do that though.

Change 363726 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] WIP: Gerrit: Add support for scap

https://gerrit.wikimedia.org/r/363726

Change 363726 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] Gerrit: Add support for scap

https://gerrit.wikimedia.org/r/363726

Change 363726 merged by Dzahn:
[operations/puppet@production] Gerrit: Add support for scap

https://gerrit.wikimedia.org/r/363726

Change 369553 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] gerrit/deployment_server: fix scap for Gerrit

https://gerrit.wikimedia.org/r/369553

Change 369553 merged by Dzahn:
[operations/puppet@production] gerrit/deployment_server: fix scap for Gerrit

https://gerrit.wikimedia.org/r/369553

It works! All we need to do is do some puppet cleanup so we symlink to the scap-deployed versions :)

Change 374667 had a related patch set uploaded (by Chad; owner: Chad):
[operations/puppet@production] Gerrit: Start using plugins from scap-deployed version

https://gerrit.wikimedia.org/r/374667

@demon I guess the final things to this task is to migrate over the plugins?

Could you build the its-phabricator plugin please? Then it will be ready to move over fully to scap :).

Then we should create a puppet patch that does what the deb mostly did? Then archive the repo for the deb (after a month of two of using scap as the permanent deployment for gerrit upgrades / plugins)

We will also need to add the systemd script to puppet. We won’t need to add the init.d one though.

The deb didn't do anything other than drop some files on a disk.

I was gonna merge https://gerrit.wikimedia.org/r/#/c/374667/3 but when i looked at /var/lib/gerrit2/review_site/plugins vs. /srv/deployment/gerrit/gerrit/plugins i saw that "its-phabricator" is only in the old place, while the other plugins are in both places.

So is that still missing and needs to be built like Paladox said above?

@Dzahn @demon has created https://gerrit.wikimedia.org/r/#/c/378192/ which includes its-phabricator :).

Not sure if he built it around https://gerrit-review.googlesource.com/#/c/gerrit/+/92830/ though.

its-phabricator included and upstream #92830 included.

thanks :).

I guess we are now ready for scap deploys :).

Change 374667 merged by Dzahn:
[operations/puppet@production] Gerrit: Start using plugins from scap-deployed version

https://gerrit.wikimedia.org/r/374667

Plugins are now deployed via scap and dropped from the deb package in return.

We only need https://gerrit.wikimedia.org/r/#/c/378768/ and https://gerrit.wikimedia.org/r/#/c/379136/ merged to close this task as resolved and then archive the gerrit deb repo.

Change 378768 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] Gerrit: Use systemd::service for systemd

https://gerrit.wikimedia.org/r/378768

Change 378768 merged by Dzahn:
[operations/puppet@production] Gerrit: Use systemd::service for systemd

https://gerrit.wikimedia.org/r/378768

I guess we can say this is resolved now :)

And close the task in a few days just to make sure everything works :)

Probably this first but ya: https://gerrit.wikimedia.org/r/#/c/384760/

Thanks +1 :)

Though before puppet runs with that change, you will probably want to move it so that I can be a symblink :).

No, puppet will just overwrite it.

Change 385100 had a related patch set (by Paladox) published:
[operations/puppet@production] Gerrit: Remove gerrit package from apt

https://gerrit.wikimedia.org/r/385100

Change 385100 merged by Dzahn:
[operations/puppet@production] Gerrit: stop installing deb package, replace with scap requires

https://gerrit.wikimedia.org/r/385100

This can now be closed as resolved :).

Change was merged. Package removed from puppet but not host.

Ok, ran apt-get purge gerrit on gerrit2001 -- it removed a couple of files so had to run puppet again so everything came back up. From what I can tell -- services are running again.

Can do on cobalt shortly, then we'll be resolved.

Purged from cobalt. Also dropped git repositories for the deb package from Github, gerrit and archived in Phab.

All that's left is an opsen to purge the debian package from our apt mirrors and we're done!!