Page MenuHomePhabricator

Article image gallery doesn't show images when offline
Closed, ResolvedPublic

Description

Steps to reproduce

  1. Open any article that contains a number of images (e.g., Peony)
  2. Tap on the lead image and swipe through to to view some images in the gallery then exit the full screen view
  3. Go offline
  4. Tap on the lead image again
  5. Go online and tap to save the article to offline
  6. Go offline
  7. Tap on the lead image or other images within the article

Expected

  • Initially (before article is saved for offline), images that were loaded in the full screen gallery should remain viewable even after user goes offline
  • After the article has been saved for offline, all images in the article image gallery should be viewable in full screen

Actual

  • Initially (before article is saved for offline), images that were loaded in the full screen gallery are no longer viewable as soon as the user goes offline
  • After the article has been saved for offline, none of the images in the article image gallery are viewable in full screen (including the lead image)
  • Additionally the licensing info is no longer accessible

open to view animated gif of actual behavior

Event Timeline

At first glance, this appears to require making an additional call to GalleryCollectionClient.request() in the service and then adding the resultant URLs to the *set* of downloaded resources. I think this will be straightforward.

Moving back to Needs triage for re-estimating based on new media endpoint.

Testing app build 2.7.268-alpha-2018-12-04 on the device Samsung Galaxy S9 SM-G960U1 (Android 8). I was able to swipe through the Peony image gallery from the lead image to the last image both before online and after offline so this seems fixed. There is one image only in the Peony image gallery that doesn't display that may be unrelated to this bug, it has a particular error message. I have attached the screencap of when it happens in case anyone wants to open a card to fix it separately.

Dbrant claimed this task.