Support cirrusDumpQuery and cirrusDumpResult query strings in all the places
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	EBernhardson
	Feb 7 2017, 7:45 PM

Description

These query strings are currently only supported for full text search. Ideally we also want them to work for:

prefix search
completion suggester
geodata api's
upcoming wikidata api's

Details

	Subject	Repo	Branch	Lines +/-
	Move request switches handling into Searcher	mediawiki/extensions/CirrusSearch	master	+60 -41

Customize query in gerrit

Event Timeline

EBernhardson created this task.Feb 7 2017, 7:45 PM

Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptFeb 7 2017, 7:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Since cirrusDump* are implemented in CirrusSearch and not Searcher, right now I'm essentially re-implementing them in my wikibase search classes. Would be great if we had an API that did it as part of Searcher. Preferably as granular as possible, since reusing big parts from another search is tricky.

There's a hack in place for this right now - but we should probably resolve this tech debt.

Change 344738 had a related patch set uploaded (by Smalyshev):
[mediawiki/extensions/CirrusSearch@master] Move request switches handling into Searcher

https://gerrit.wikimedia.org/r/344738

gerritbot added a project: Patch-For-Review.Mar 28 2017, 1:13 AM

Smalyshev moved this task from This Quarter to Current work on the Discovery-Search board.Mar 28 2017, 1:20 AM

Smalyshev edited projects, added Discovery-Search (Current work); removed Discovery-Search.

Smalyshev moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.

Change 344738 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Move request switches handling into Searcher

https://gerrit.wikimedia.org/r/344738

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)).Mar 28 2017, 2:00 PM

prefix search

This one uses the DB AFAIK so not sure what we'd dump there

completion suggester

This is a tricky one since it doesn't use Searcher but another ElasticsearchIntermediary class. We could move the debugging infrastructure into a trait or into ElasticsearchIntermediary to make it work with such cases.

geodata api's

This already should work for Geodata feature(s) (it being the regular search essentially) but not for query/coordinates which doesn't use ES anyway. Not sure what we'd dump in the latter case.