Reason for this would be that img are printed, while most browsers generally hide background images. Thus currently pages with maps when printed tend to have nice empty squares
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use img tag for the map instead of background | mediawiki/extensions/Kartographer | master | +78 -49 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T43307 Alow comparison with old revisions while editing an old version of a page | |||
| Resolved | TheDJ | T70008 PDF-related improvements needed at Wikivoyage, especially for dynamic maps | |||
| Resolved | • JGirault | T155328 Review/merge community contribution in https://gerrit.wikimedia.org/r/#/c/331942 | |||
| Resolved | TheDJ | T157512 Use an <img> element inside the <a> link rather than a background image to facilitate printing |
Event Timeline
Comment Actions
Moving off the sprint board - the Discovery team won't be able to do this work at this time.
Comment Actions
Change 581129 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/Kartographer@master] Use img tag for the map instead of background
Comment Actions
Change 581129 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Use img tag for the map instead of background
Comment Actions
@MSantos @Jdforrester-WMF hmm. small question.... is this gonna make disk usage explode due to the increase in generated tiles ? Can we handle that ? I have no idea how many tiles we have and how long we store them.
Comment Actions
The JS code already uses (and thus implicitly creates) the @2x tiles, right? I doubt there's a huge number of pages with maps that get only non-JS renders…
Comment Actions
No, the non-JS is a separate rendered image, it is not the same as the JS tiles.
I'm unsure how they are stored... if it's on the same server, i'm guessing compared to the live tiles, it shouldn't be a major amount of images.