Page MenuHomePhabricator
Create Task
Maniphest T157515

Notice: Undefined variable: latest in /srv/mediawiki/php-1.29.0-wmf.11/extensions/MobileFrontend/includes/api/ApiMobileView.php on line 499
Closed, ResolvedPublic2 Estimated Story PointsPRODUCTION ERROR
Actions

Description

This has started happening with some frequency after the wmf.11 rollout to group0

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendwmf/1.29.0-wmf.11+5 -3Pass revision id to parseSectionsData to avoid warnings
mediawiki/extensions/MobileFrontendmaster+5 -3Pass revision id to parseSectionsData to avoid warnings
Customize query in gerrit

Related Objects
Search...

Event Timeline

• thcipriani created this task.Feb 8 2017, 12:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2017, 12:12 AM
• thcipriani added a parent task: T155526: MW-1.29.0-wmf.11 deployment blockers.Feb 8 2017, 12:13 AM
• thcipriani triaged this task as Unbreak Now! priority.Feb 8 2017, 12:18 AM

Changing to UBN! since I added it as a blocker to 1.29.0-wmf.11 as it's a particularly noisy message even only just being deployed in group0.

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptFeb 8 2017, 12:18 AM
• thcipriani assigned this task to Jdlrobson.Feb 8 2017, 3:44 PM
• thcipriani added a subscriber: Jdlrobson.

@Jdlrobson looks like this one may have come from rEMFRb68f5d2fcc09: Merge "Hygiene: breakup mega-function in MobileView API"—$latest was moved out of scope there. Could you take a look at this one, please? Feel free to pass the "assign/claim" hot potato as appropriate—I tagged you after a quick glance at git blame.

Jdlrobson removed Jdlrobson as the assignee of this task.Feb 8 2017, 3:48 PM
Jdlrobson added projects: Reading-Web-Sprint-91-🐔🍔, Readers-Web-Backlog, Unplanned-Sprint-Work.
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-91-🐔🍔 board.
bmansurov moved this task from Incoming to 2016-17 Q3 on the Readers-Web-Backlog board.Feb 8 2017, 4:37 PM
MBinder_WMF set the point value for this task to 1.Feb 8 2017, 6:07 PM
MBinder_WMF changed the point value for this task from 1 to 2.
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-91-🐔🍔 board.Feb 8 2017, 7:26 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Reading-Web-Sprint-91-🐔🍔 board.Feb 8 2017, 7:47 PM
gerritbot added a subscriber: gerritbot.Feb 8 2017, 7:47 PM

Change 336667 had a related patch set uploaded (by Jdlrobson):
Pass revision id to parseSectionsData to avoid warnings

https://gerrit.wikimedia.org/r/336667

gerritbot added a project: Patch-For-Review.Feb 8 2017, 7:47 PM
gerritbot added a comment.Feb 8 2017, 8:27 PM

Change 336676 had a related patch set uploaded (by Thcipriani):
Pass revision id to parseSectionsData to avoid warnings

https://gerrit.wikimedia.org/r/336676

gerritbot added a comment.Feb 8 2017, 8:38 PM

Change 336667 merged by jenkins-bot:
Pass revision id to parseSectionsData to avoid warnings

https://gerrit.wikimedia.org/r/336667

gerritbot added a comment.Feb 8 2017, 8:43 PM

Change 336676 merged by jenkins-bot:
Pass revision id to parseSectionsData to avoid warnings

https://gerrit.wikimedia.org/r/336676

Stashbot added a subscriber: Stashbot.Feb 8 2017, 8:47 PM

Mentioned in SAL (#wikimedia-operations) [2017-02-08T20:47:07Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.11/extensions/MobileFrontend/includes/api/ApiMobileView.php: [[gerrit:336676|Pass revision id to parseSectionsData to avoid warnings]] T157515 (duration: 00m 42s)

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-91-🐔🍔 board.Feb 8 2017, 8:48 PM
Jdlrobson closed this task as Resolved.Feb 8 2017, 8:50 PM
Jdlrobson claimed this task.

This has now been deployed thanks to @thcipriani and I just verified with him that the problem has gone from group0 wikis. Good work all!

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)).Feb 8 2017, 9:00 PM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL