Page MenuHomePhabricator

The link in the "privacy considerations" flyout on PDF file description pages is difficult to click
Closed, ResolvedPublic

Description

  1. Visit a PDF file like https://commons.wikimedia.org/wiki/File:Sample_Syllabus_for_Wikipedia_assignment.pdf.
  2. Hover the mouse over the orange text "application/pdf" beneath the first page of the PDF file.
  3. Now try to click the "read more" link in the text of the popup.

You can't do it, because the popup disappears as soon as the mouse leaves the "application/pdf" text. You can only click the link if you move the mouse via the exclamation icon.

The popup should have a timeout, in order to give the user a chance to move the mouse and click the link.

(Not sure whether this is an OOUI issue or something that can be fixed in PdfHandler itself.)

Event Timeline

TTO created this task.Feb 8 2017, 10:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2017, 10:39 AM
matmarex added a subscriber: matmarex.

OOjs UI doesn't currently support popups on hover (T88630), this is custom code in MediaWiki. (It's actually in core, not in PdfHandler.) The code is in /resources/src/mediawiki/mediawiki.filewarning.js and .less. I suspect this is the result of the fix for T153701: PopupWidget overlaps content beneath it.

Restricted Application added projects: Multimedia, Commons. · View Herald TranscriptFeb 8 2017, 4:40 PM
dr0ptp4kt triaged this task as Normal priority.Jun 26 2017, 3:28 PM
dr0ptp4kt moved this task from Untriaged to Needs Design on the Multimedia board.
dr0ptp4kt added subscribers: Nirzar, dr0ptp4kt.

@Nirzar would you please provide a desired treatment (however simple) ?

matmarex claimed this task.Jun 26 2017, 4:23 PM

Screenshot for future reference.

Change 361480 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] mw.filewarning: Increase the area of the warning button

https://gerrit.wikimedia.org/r/361480

Jdforrester-WMF closed this task as Resolved.Jun 26 2017, 4:37 PM

Change 361480 merged by jenkins-bot:
[mediawiki/core@master] mw.filewarning: Increase the area of the warning button

https://gerrit.wikimedia.org/r/361480

This does not happen in OOJS UI here -->

https://doc.wikimedia.org/oojs-ui/master/demos/#widgets-wikimediaui-ltr-desktop

I would avoid any specific delays to popovers on client of OOJS UI. there must be some other explanation of this happening.

This is only an issue with popups on hover, rather than on click. I fixed it by making the area below the button (see my screenshot above) still trigger the hover effect.