SerializerFactory currently only supports Items and Properties. To change this, the logic that currently resides in WikibaseRepo::getEntitySerializer() should be moved to SerializerFactory::newEntitySerializer(). WikibaseRepo::getEntitySerializer() should just delegate to SerializerFactory.
Patches for review:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use new DataModel Serialization 3.0 factories features | mediawiki/extensions/Wikibase | master | +44 -54 |
Change 336781 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Use new DataModel Serialization 2.3 factory feature
Change 338749 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Better names for WikibaseRepo/Client (de)serializer factory methods
Change 336781 abandoned by Thiemo Mättig (WMDE):
Use new DataModel Serialization 3.0 factories features
Reason:
Wrong approach, this component is not supposed to support other entity types. See Ic126c46 instead.
If the Serializer returned by SerializerFactory::newEntitySerializer() is not meant to support custom entity types, we should remove it, or at least stop using it. See T160436.
If there was a user of this, it was an accident. The actual issue we had got fixed with https://gerrit.wikimedia.org/r/342642. Discussion continues in T160436 and T160439.