Page MenuHomePhabricator
Create Task
Maniphest T157619

Notice: Undefined index: X in /srv/mediawiki/php-1.29.0-wmf.11/skins/CologneBlue/SkinCologneBlue.php on line Y
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Seeing these with the rollout of 1.29.0-wmf.11 to group1

Notice: Undefined index: addsection in /srv/mediawiki/php-1.29.0-wmf.11/skins/CologneBlue/SkinCologneBlue.php on line 492
Notice: Undefined index: createaccount in /srv/mediawiki/php-1.29.0-wmf.11/skins/CologneBlue/SkinCologneBlue.php on line 458
Notice: Undefined index: emailuser in /srv/mediawiki/php-1.29.0-wmf.11/skins/CologneBlue/SkinCologneBlue.php on line 197
Notice: Undefined index: login in /srv/mediawiki/php-1.29.0-wmf.11/skins/CologneBlue/SkinCologneBlue.php on line 458
Notice: Undefined index: protect in /srv/mediawiki/php-1.29.0-wmf.11/skins/CologneBlue/SkinCologneBlue.php on line 217
Notice: Undefined index: undelete in /srv/mediawiki/php-1.29.0-wmf.11/skins/CologneBlue/SkinCologneBlue.php on line 211
Notice: Undefined index: unprotect in /srv/mediawiki/php-1.29.0-wmf.11/skins/CologneBlue/SkinCologneBlue.php on line 222

Details

ProjectBranchLines +/-Subject
mediawiki/skins/CologneBluewmf/1.29.0-wmf.11+78 -30Fix remaining undefined index notices
mediawiki/skins/CologneBluemaster+78 -30Fix remaining undefined index notices
mediawiki/skins/CologneBluewmf/1.29.0-wmf.11+31 -21Fix a bunch of undefined indexes
mediawiki/skins/CologneBluemaster+31 -21Fix a bunch of undefined indexes
Customize query in gerrit

Related Objects

Event Timeline

thcipriani created this task.Feb 8 2017, 9:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2017, 9:11 PM
matmarex added subscribers: ashley, matmarex.Feb 8 2017, 9:18 PM

These were probably surfaced by https://gerrit.wikimedia.org/r/#/c/336415/ and if so, don't indicate any new serious problems. Probably just needs a sprinkle of isset(). @ashley Wanna fix?

gerritbot added a subscriber: gerritbot.Feb 8 2017, 9:58 PM

Change 336714 had a related patch set uploaded (by Jack Phoenix):
Fix a bunch of undefined indexes

https://gerrit.wikimedia.org/r/336714

gerritbot added a project: Patch-For-Review.Feb 8 2017, 9:58 PM
demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Feb 8 2017, 10:46 PM
thcipriani added a parent task: T155526: MW-1.29.0-wmf.11 deployment blockers.Feb 9 2017, 8:17 PM
gerritbot added a comment.Feb 9 2017, 8:19 PM

Change 336885 had a related patch set uploaded (by Thcipriani):
Fix a bunch of undefined indexes

https://gerrit.wikimedia.org/r/336885

gerritbot added a comment.Feb 9 2017, 8:21 PM

Change 336714 merged by jenkins-bot:
Fix a bunch of undefined indexes

https://gerrit.wikimedia.org/r/336714

gerritbot added a comment.Feb 9 2017, 8:25 PM

Change 336885 merged by jenkins-bot:
Fix a bunch of undefined indexes

https://gerrit.wikimedia.org/r/336885

Stashbot added a subscriber: Stashbot.Feb 9 2017, 8:41 PM

Mentioned in SAL (#wikimedia-operations) [2017-02-09T20:41:05Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.11/skins/CologneBlue/CologneBlue.php: [[gerrit:336714|Fix a bunch of undefined indexes]] T157619 (duration: 00m 41s)

Stashbot added a comment.Feb 9 2017, 8:45 PM

Mentioned in SAL (#wikimedia-operations) [2017-02-09T20:45:20Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.11/skins/CologneBlue/SkinCologneBlue.php: [[gerrit:336714|Fix a bunch of undefined indexes]] T157619 (sync actual skin file) (duration: 00m 40s)

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)).Feb 9 2017, 9:00 PM
gerritbot added a comment.Feb 9 2017, 9:49 PM

Change 336908 had a related patch set uploaded (by Thcipriani):
Fix remaining undefined index notices

https://gerrit.wikimedia.org/r/336908

gerritbot added a comment.Feb 9 2017, 10:12 PM

Change 336908 merged by jenkins-bot:
Fix remaining undefined index notices

https://gerrit.wikimedia.org/r/336908

gerritbot added a comment.Feb 9 2017, 10:13 PM

Change 336917 had a related patch set uploaded (by Thcipriani):
Fix remaining undefined index notices

https://gerrit.wikimedia.org/r/336917

gerritbot added a comment.Feb 9 2017, 10:16 PM

Change 336917 merged by jenkins-bot:
Fix remaining undefined index notices

https://gerrit.wikimedia.org/r/336917

thcipriani added a comment.Feb 9 2017, 10:31 PM

Well that last patch of mine didn't work. For now I'm going to revert https://gerrit.wikimedia.org/r/#/c/336415/

I don't like suppressing these notices; however, I can't roll the train forward because these errors are causing spikes in logstash (https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train#Issues_that_hold_the_train see "Large error-rate increases).

Stopping the train due to errors that have existed for a long time seems wrong, too. Therefore, I'm going to revert the removal of error suppression and roll forward.

thcipriani removed a parent task: T155526: MW-1.29.0-wmf.11 deployment blockers.Feb 9 2017, 11:09 PM
matmarex added a comment.Feb 14 2017, 8:37 PM

This is resolved now? Or not?

matmarex closed this task as Resolved.Mar 17 2017, 1:05 PM

Looks like this was fixed with rSCBL2b629a8bb98a: Revert "Remove warning suppression".

Reedy removed projects: MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), Patch-For-Review.May 17 2019, 9:44 PM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL