Page MenuHomePhabricator

Anniversaries crash for unsupported wikis
Closed, ResolvedPublic

Description

For wikis where anniversaries are not supported the service crashes with 500 error.

Example: http://appservice.wmflabs.org/ru.wikipedia.org/v1/onthisday/selected/05/22
Error: Cannot read property 'monthNames' of undefined

Details

Related Gerrit Patches:
mediawiki/services/mobileapps : masterOn this day: throw 501 for unsupported language

Event Timeline

Pchelolo created this task.Feb 9 2017, 1:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2017, 1:29 AM
Pchelolo assigned this task to bearND.Feb 9 2017, 1:31 AM
Pchelolo triaged this task as High priority.

We can't deploy the public endpoints until this is fixed, so setting the priority to High.

bearND added a comment.Feb 9 2017, 4:46 AM

404 OK in this case?

mobrovac added a subscriber: mobrovac.EditedFeb 9 2017, 5:36 AM

404 OK in this case?

We should be consistent with unsupported languages across all of MCS, so I would suggest 501.

For the public endpoint, though, we probably want to expose the endpoint only for enwiki, and not for the others at this time.

bearND added a comment.Feb 9 2017, 5:47 AM

Sounds good. Thanks!

For the public endpoint, though, we probably want to expose the endpoint only for enwiki, and not for the others at this time.

It's actually supported for more wikis. I think we can expose for all, our configs are getting way to complicated...

Change 336884 had a related patch set uploaded (by BearND):
On this day: throw 501 for unsupported language

https://gerrit.wikimedia.org/r/336884

For the public endpoint, though, we probably want to expose the endpoint only for enwiki, and not for the others at this time.

It's actually supported for more wikis. I think we can expose for all, our configs are getting way to complicated...

Yeah, disregard my comment. +1 on exposing it for *.wp.org (to keep our sanity).

Change 336884 merged by jenkins-bot:
On this day: throw 501 for unsupported language

https://gerrit.wikimedia.org/r/336884

Let's keep the ticket open until this is deployed in production so that we can keep track.

Pchelolo closed this task as Resolved.Feb 13 2017, 10:41 PM

It's been deployed, so we're good. Resolving.