When you change .gitmodules URLs, you need to run git submodule sync before git submodule update. It looks like scap currently doesn't handle this. Scap should probably just always run git submodule sync before update in case there were any changes to .gitmodules.
Description
Description
Details
Details
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Call git submodule sync before git submodule update | repos/releng/scap!130 | dancy | master-c5d7 | master |
Revisions and Commits
Revisions and Commits
| Restricted Differential Revision |
Related Objects
Related Objects
Event Timeline
Comment Actions
Probably add sync_submodules() here: https://phabricator.wikimedia.org/source/scap/browse/master/scap/git.py;bf6443a7ba1be34f9418408ca8d0ae049c9f7101$319
Comment Actions
@Halfak thank you for the fix!
This is in the currently deployed version of scap (went out with version 3.5.2-1).
Comment Actions
dancy opened https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/130
Call git submodule sync before git submodule update
Comment Actions
dancy merged https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/130
Call git submodule sync before git submodule update