"New section" tab (added by NEWSECTIONLINK) does not work when VE is active and in two tab mode
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

Make you have both Edit and Edit Source tab enabled
Click on Edit tab to open VE
Open VisualEditor
Click on "New Section" tab

Nothing happens.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	DesktopArticleTarget.init: handle new-section tab when in visual mode	mediawiki/extensions/VisualEditor	master	+4 -2

Customize query in gerrit

Related Objects

Mentioned In: T198272: [Regression pre-wmf.10] After making an edit, clicking on "Edit Source" while VE is open, does not switch the editor anymore

Event Timeline

Ryasmeen created this task.Feb 10 2017, 12:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 10 2017, 12:34 AM

Ryasmeen renamed this task from [Regression wmf.11] "New section" tab does not work when you click on it while VE is active and the preference for having both editors tabs is enabled. to [Regression ?] "New section" tab does not work when you click on it while VE is active and the preference for having both editors tabs is enabled..Feb 10 2017, 12:34 AM

What page are you testing on? If you have 'new section' you probably shouldn't have VE enabled (just NWE).

Esanders updated the task description. (Show Details)Feb 11 2017, 7:00 PM

I tested on my sandbox on en.wiki and Beta : https://en.wikipedia.beta.wmflabs.org/wiki/User:RYasmeen_(WMF)

But it is reproducible on any page really with the same options enabled.

I have both Editors tabs enabled from Preferences>Editing and also the tab for "New section" is enabled from Page Options section.

Screen Shot 2017-02-12 at 1.15.09 AM.png (406×1 px, 142 KB)

This page shouldn't have a 'New section' tab on it, but there is a NEWSECTIONLINK keyword.

Esanders renamed this task from [Regression ?] "New section" tab does not work when you click on it while VE is active and the preference for having both editors tabs is enabled. to [Regression ?] "New section" tab added by __NEWSECTIONLINK__ does not work when VE is active and in two tab mode..Feb 12 2017, 9:17 PM

Jdforrester-WMF triaged this task as Medium priority.Feb 14 2017, 8:06 PM

Jdforrester-WMF added a project: VisualEditor-MediaWiki.

Jdforrester-WMF set the point value for this task to 1.

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

AFAICT not a regression, but yes we should fix this. Amazing spot.

Change 377301 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: handle new-section tab when in visual mode

https://gerrit.wikimedia.org/r/377301

gerritbot added a project: Patch-For-Review.Sep 11 2017, 4:34 PM

Change 377301 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: handle new-section tab when in visual mode

https://gerrit.wikimedia.org/r/377301

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Sep 20 2017, 6:00 PM

• Deskana closed this task as Resolved.Oct 17 2017, 5:13 PM

• Deskana assigned this task to DLynch.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 17 2017, 5:13 PM

Ryasmeen added projects: Verified, Verified-in-Phase0, Verified-in-Phase2.Oct 17 2017, 6:14 PM

DLynch mentioned this in T198272: [Regression pre-wmf.10] After making an edit, clicking on "Edit Source" while VE is open, does not switch the editor anymore.Jul 2 2018, 9:32 PM

	F5611709: Screen Shot 2017-02-12 at 1.15.09 AM.png
	Feb 12 2017, 1:22 AM

"New section" tab (added by __NEWSECTIONLINK__) does not work when VE is active and in two tab modeClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

"New section" tab (added by NEWSECTIONLINK) does not work when VE is active and in two tab mode
Closed, ResolvedPublic1 Estimated Story Points
Actions