Description

This is not at all urgent. It's just null and not hurting anything. However, I've removed it from the codebase, so I just wanted to let you know, so it can be scheduled at some point.

https://gerrit.wikimedia.org/r/#/c/336903/

ALTER: https://phabricator.wikimedia.org/diffusion/EPTR/browse/master/sql/PageTriageLogPatch_Drop_ptrl_comment.sql
All wikis with pagetriage_log, which should be the same as where PageTriage is enabled (enwiki, testwiki, test2wiki).
It can be run at any time, and is backwards-compatible.
It was automatically applied on Beta successfully via update.php.

Sorry for not following the workflow.

Progress:

s1 - enwiki
s3 - testwiki
s3 - test2wiki

Event Timeline

• Mattflaschen-WMF created this task.Feb 10 2017, 2:27 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptFeb 10 2017, 2:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Mattflaschen-WMF moved this task from Untriaged to External on the Collaboration-Team-Triage board.Feb 10 2017, 2:28 AM

• Mattflaschen-WMF mentioned this in T157056: Remove the 250 character limit from messages sent through the Page Curation Tool.

Reedy moved this task from Unsorted to Delete / Drop / Remove on the Schema-change board.Apr 26 2017, 2:21 PM

Umherirrender added a project: Blocked-on-schema-change.Apr 28 2017, 2:51 PM

Marostegui triaged this task as Medium priority.Jun 21 2017, 11:49 AM

As per comment, there is noone blocked there, this is a regular DBA cleanup task. Thanks for reporting- it helps making things cleaner.

jcrespo moved this task from Triage to Backlog on the DBA board.Mar 5 2018, 10:42 AM

This table only exists on

s1 (enwiki) 352711 rows
s3 (testwiki) 162 rows
s3 (test2wiki) 77 rows

Marostegui updated the task description. (Show Details)Mar 23 2018, 2:41 PM

I have renamed the column on testwiki and test2wiki on db2036 to make sure nothing breaks:

+------------+
| @@hostname |
+------------+
| db2036     |
+------------+
1 row in set (0.04 sec)

root@db2036.codfw.wmnet[test2wiki]> show create table testwiki.pagetriage_log\G show create table test2wiki.pagetriage_log\G
*************************** 1. row ***************************
       Table: pagetriage_log
Create Table: CREATE TABLE `pagetriage_log` (
  `ptrl_id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `ptrl_page_id` int(10) unsigned NOT NULL,
  `ptrl_user_id` int(10) unsigned NOT NULL,
  `ptrl_reviewed` tinyint(3) unsigned NOT NULL DEFAULT '0',
  `TO_DROP_ptrl_comment` varbinary(255) DEFAULT NULL,
  `ptrl_timestamp` varbinary(14) NOT NULL,
  PRIMARY KEY (`ptrl_id`),
  KEY `ptrl_page_id_timestamp` (`ptrl_page_id`,`ptrl_timestamp`),
  KEY `ptrl_timestamp` (`ptrl_timestamp`)
) ENGINE=InnoDB AUTO_INCREMENT=3389 DEFAULT CHARSET=binary
1 row in set (0.04 sec)

*************************** 1. row ***************************
       Table: pagetriage_log
Create Table: CREATE TABLE `pagetriage_log` (
  `ptrl_id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `ptrl_page_id` int(10) unsigned NOT NULL,
  `ptrl_user_id` int(10) unsigned NOT NULL,
  `ptrl_reviewed` tinyint(3) unsigned NOT NULL DEFAULT '0',
  `TO_DROP_ptrl_comment` varbinary(255) DEFAULT NULL,
  `ptrl_timestamp` varbinary(14) NOT NULL,
  PRIMARY KEY (`ptrl_id`),
  KEY `ptrl_page_id_timestamp` (`ptrl_page_id`,`ptrl_timestamp`),
  KEY `ptrl_timestamp` (`ptrl_timestamp`)
) ENGINE=InnoDB AUTO_INCREMENT=6975 DEFAULT CHARSET=binary
1 row in set (0.04 sec)

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 25 2018, 10:29 AM

Same on db2055 (enwiki):

root@db2055.codfw.wmnet[enwiki]> show create table pagetriage_log\G
*************************** 1. row ***************************
       Table: pagetriage_log
Create Table: CREATE TABLE `pagetriage_log` (
  `ptrl_id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `ptrl_page_id` int(10) unsigned NOT NULL,
  `ptrl_user_id` int(10) unsigned NOT NULL,
  `ptrl_reviewed` tinyint(3) unsigned NOT NULL DEFAULT '0',
  `TO_DROP_ptrl_comment` varbinary(255) DEFAULT NULL,
  `ptrl_timestamp` varbinary(14) NOT NULL,
  PRIMARY KEY (`ptrl_id`),
  KEY `ptrl_page_id_timestamp` (`ptrl_page_id`,`ptrl_timestamp`),
  KEY `ptrl_timestamp` (`ptrl_timestamp`)
) ENGINE=InnoDB AUTO_INCREMENT=4727957 DEFAULT CHARSET=binary
1 row in set (0.04 sec)

SBisson moved this task from Inbox to External on the Growth-Team board.Jul 25 2018, 12:40 PM

Marostegui updated the task description. (Show Details)Aug 2 2018, 7:56 AM

Marostegui closed this task as Resolved.Aug 3 2018, 7:34 AM

Marostegui claimed this task.

Marostegui updated the task description. (Show Details)

Drop ptrl_comment in production
Closed, ResolvedPublic
Actions

Description

Related Objects

Event Timeline

Drop ptrl_comment in productionClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Drop ptrl_comment in production
Closed, ResolvedPublic
Actions