Page MenuHomePhabricator
Create Task
Maniphest T157800

RevisionSlider UI elements dimensions look odd
Closed, ResolvedPublic
Actions

Description

Some UI elements look really odd (e.g. pin-button, timeline arrow-elements). See the attached screenshot.
Probably caused by some changes to OOJS-UI?

rs_oojsui_elements_odd.jpg (249×1 px, 57 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Don't set min-height and min-width for oo-ui buttonsmediawiki/extensions/RevisionSliderwmf/1.29.0-wmf.11+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Tobi_WMDE_SW created this task.Feb 10 2017, 2:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 10 2017, 2:03 PM
Tobi_WMDE_SW triaged this task as High priority.EditedFeb 10 2017, 2:03 PM
Tobi_WMDE_SW moved this task from Proposed to Todo on the WMDE-TechWish board.

Seems like this is already happening in production as well.

MichaelSchoenitzer unsubscribed.Feb 10 2017, 2:11 PM
• MichaelSchoenitzer_WMDE subscribed.Feb 10 2017, 2:11 PM
Tobi_WMDE_SW added a comment.Feb 10 2017, 2:19 PM

Seems to be caused by https://gerrit.wikimedia.org/r/#/c/335570/

Tobi_WMDE_SW claimed this task.Feb 10 2017, 2:28 PM
Tobi_WMDE_SW moved this task from Todo to Sprint ready on the WMDE-TechWish board.
Tobi_WMDE_SW moved this task from Sprint ready to Done on the WMDE-TechWish board.Feb 10 2017, 2:57 PM
gerritbot subscribed.Feb 10 2017, 3:43 PM

Change 337030 had a related patch set uploaded (by WMDE-Fisch):
Don't set min-height and min-width for oo-ui buttons

https://gerrit.wikimedia.org/r/337030

gerritbot added a project: Patch-For-Review.Feb 10 2017, 3:43 PM
WMDE-Fisch mentioned this in rERSL62f4dedf4181: Don't set min-height and min-width for oo-ui buttons.Feb 10 2017, 3:43 PM
gerritbot added a comment.Feb 13 2017, 2:14 PM

Change 337030 merged by jenkins-bot:
Don't set min-height and min-width for oo-ui buttons

https://gerrit.wikimedia.org/r/337030

Stashbot subscribed.Feb 13 2017, 2:18 PM

Mentioned in SAL (#wikimedia-operations) [2017-02-13T14:18:27Z] <addshore@tin> Synchronized php-1.29.0-wmf.11/extensions/RevisionSlider/modules/ext.RevisionSlider.css: T157800 [[gerrit:337030|Dont set min-height and min-width for oo-ui buttons]] 1/2 (duration: 01m 07s)

Stashbot added a comment.Feb 13 2017, 2:19 PM

Mentioned in SAL (#wikimedia-operations) [2017-02-13T14:19:43Z] <addshore@tin> Synchronized php-1.29.0-wmf.11/extensions/RevisionSlider/modules/ext.RevisionSlider.lazy.css: T157800 [[gerrit:337030|Dont set min-height and min-width for oo-ui buttons]] 2/2 (duration: 00m 55s)

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)).Feb 13 2017, 3:00 PM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Feb 14 2017, 3:41 PM
WMDE-Fisch moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Feb 14 2017, 5:36 PM
Tobi_WMDE_SW closed this task as Resolved.Feb 21 2017, 2:30 PM
Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 12:00 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits