Page MenuHomePhabricator

RCFilters UI: When removing a capsule item, its popup remains visible
Closed, ResolvedPublic


If we remove a capsule item, the fact we're hovering over it makes the popup appear - and yet it doesn't go away when we click the 'x' button of the capsule.

To reproduce:

  1. Go to Special:RecentChanges, choose a couple of filters to appear in the capsule
  2. Remove one filter from the capsule, by clicking its "x" button (note - the popup appears as you hover)
  3. The popup should go away when the capsule item vanishes

Event Timeline

Change 337208 had a related patch set uploaded (by Mooeypoo):
RCFilters UI: Destroy CapsuleItemWidget when it is removed

Change 337208 merged by jenkins-bot:
RCFilters UI: Destroy CapsuleItemWidget when it is removed

Checked in betalabs - all the cases below have been fixed.

QA recommendation: Resolve.

Before behavior:
"Sticky" tooltips

Screen Shot 2017-02-09 at 3.23.26 PM.png (406×921 px, 128 KB)

Screen Shot 2017-02-09 at 3.23.39 PM.png (441×843 px, 140 KB)

Screen Shot 2017-02-09 at 3.32.40 PM.png (371×1 px, 132 KB)

When the page is scrolled up:

Screen Shot 2017-02-09 at 3.24.01 PM.png (493×857 px, 130 KB)

@Mooeypoo Every time I click on selected filter with a tooltip dispalyed, I got the Console errors (look below). It doesn't seem to be affecting anything - any concerns about it?

Uncaught TypeError: Cannot read property 'val' of null(…)

With filters "Newcomers", "Unregistered" (conflicting state), the click on selected greyed-out filters gives

Uncaught TypeError: Cannot read property 'val' of null
 at MwRcfiltersUiFilterCapsuleMultiselectWidget.OO.ui.CapsuleMultiselectWidget.editItem (eval at <anonymous>
 at MwRcfiltersUiCapsuleItemWidget.OO.ui.CapsuleItemWidget.onClick (eval at <anonymous> 
 at HTMLDivElement.dispatch
 at HTMLDivElement.elemData.handle

Split the Uncaught TypeError stuff into a separate ticket - T158368 for better prioritization.