JS errors in MobileFrontend in Main Pages of some Wikimedia sites with $container = null in createBanner in cleanuptemplates.js
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Amire80
	Feb 11 2017, 10:06 AM

Description

To reproduce:

Open JS console
Go to https://en.m.wikipedia.org/wiki/Main_Page?debug=true

Observed:

cleanuptemplates.js?4ad4e:54 Uncaught TypeError: Cannot read property 'find' of null
    at createBanner (cleanuptemplates.js?4ad4e:54)
    at initPageIssues (cleanuptemplates.js?4ad4e:104)
    at cleanuptemplates.js?4ad4e:117
    at cleanuptemplates.js?4ad4e:118
    at cleanuptemplates.js?4ad4e:120
createBanner @ cleanuptemplates.js?4ad4e:54
initPageIssues @ cleanuptemplates.js?4ad4e:104
(anonymous) @ cleanuptemplates.js?4ad4e:117
(anonymous) @ cleanuptemplates.js?4ad4e:118
(anonymous) @ cleanuptemplates.js?4ad4e:120

This happens in this code in cleanuptemplates.js:

		function createBanner( $container, labelText, headingText ) {
			var selector = 'table.ambox, table.tmbox, table.cmbox',
				$metadata = $container.find( selector ), // <----- HERE
				issues = [],
				$link;

This happens consistently:

in Chrome and Firefox
logged-in and logged-out
with debug=true and without it
in English and Hebrew Wikipedias, but only on the Main Page. I couldn't consistently reproduce it in the German Wikipedia or in English Wikipedia articles other than the Main Page.

Event Timeline

Amire80 created this task.Feb 11 2017, 10:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2017, 10:06 AM

Nemo_bis subscribed.Feb 11 2017, 10:10 AM

$container = ns === 14 ? $( '#bodyContent' ) :
M.getCurrentPage().getLeadSectionElement();
createBanner( $container, etc.....

So if it probably fails to find the lead section, and this will likely be null (should probably be empty jquery collection instead) and this null value is then passed to createBanner.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptFeb 13 2017, 10:27 AM

TheDJ triaged this task as Low priority.Feb 13 2017, 10:27 AM

• bmansurov closed this task as a duplicate of T157985: Production JS error on MainPage.Feb 22 2017, 2:36 PM

JS errors in MobileFrontend in Main Pages of some Wikimedia sites with $container = null in createBanner in cleanuptemplates.jsClosed, DuplicatePublicActions

Description

Event Timeline

JS errors in MobileFrontend in Main Pages of some Wikimedia sites with $container = null in createBanner in cleanuptemplates.js
Closed, DuplicatePublic
Actions