Page MenuHomePhabricator

Rewrite OO.ui.prompt to extend MessageDialog
Open, NormalPublic

Description

OO.ui.prompt uses a bit hacky way to be displayed. Lets create new class extending MessageDialog.
https://github.com/wikimedia/oojs-ui/blob/3d5dfc4bb80ef701986a62c8194e67e3bac8b167/src/windows.js#L117

Event Timeline

Filip created this task.Feb 11 2017, 6:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2017, 6:52 PM
Filip claimed this task.Feb 11 2017, 7:21 PM

Sending screenshot, need to implemet actions now

Zeto87 moved this task from Backlog to Reviewing on the OOUI board.Feb 11 2017, 7:59 PM
Filip removed Filip as the assignee of this task.Mar 6 2017, 2:14 PM

Not blocking it, don't have time to finish it for now.

Volker_E moved this task from Reviewing to Next-up on the OOUI board.Apr 28 2017, 11:03 PM
Jdforrester-WMF renamed this task from Fix code of OO.ui.prompt to extend MessageDialog. to Rewrite OO.ui.prompt to extend MessageDialog.Jun 28 2017, 7:39 PM
Jdforrester-WMF triaged this task as Normal priority.

I'd set the priority to Low, the code isn't too hacky. Also, I feel (and might be wrong), that extending MessageDialog to do this might make the code more complex than it is now.