Page MenuHomePhabricator

WikibaseMediaInfoHooksTest::testOnImagePageAfterImageLinks failure
Closed, DuplicatePublic

Description

How entityNamespaces and namespace registration in Wikibase (especially, with WikibaseClient enabled) changed in https://gerrit.wikimedia.org/r/#/c/337255/

This causes registration of extra entity namespaces not to work correctly.

Presumably this also affects WikibaseLexeme.

One thing we could do to improve is to define the namespaces in extension registration, instead of onSetupAfterCache hook. We also need to call WikibaseEntityNamespaces hook earlier in setup.

10:08:22 There was 1 failure:
10:08:22 
10:08:22 1) Wikibase\MediaInfo\Tests\MediaWiki\WikibaseMediaInfoHooksTest::testOnImagePageAfterImageLinks
10:08:22 Failed asserting that '<h2><a href="/wiki/index.php/:M23" title=":M23">:M23</a></h2>' matches PCRE pattern "@<h2><a .*MediaInfo:M23.*>MediaInfo:M23</a></h2>@".
10:08:22 
10:08:22 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/WikibaseMediaInfoHooksTest.php:130
10:08:22 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/maintenance/doMaintenance.php:111
10:08:22

Event Timeline

Change 337349 had a related patch set uploaded (by Aude):
Use extension registration for namespaces

https://gerrit.wikimedia.org/r/337349

Change 337350 had a related patch set uploaded (by Aude):
Call WikibaseEntityNamespaces hook earlier in setup [WIP]

https://gerrit.wikimedia.org/r/337350

thiemowmde triaged this task as High priority.
thiemowmde moved this task from incoming to in progress on the Wikidata board.
thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
thiemowmde updated the task description. (Show Details)

Change 337884 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Rename and cleanup fetching of all entityNamespaces settings

https://gerrit.wikimedia.org/r/337884

Change 337350 merged by jenkins-bot:
Call WikibaseEntityNamespaces hook earlier in setup

https://gerrit.wikimedia.org/r/337350

Change 337349 merged by jenkins-bot:
Use extension registration for namespaces

https://gerrit.wikimedia.org/r/337349

Change 337884 merged by jenkins-bot:
Rename and cleanup fetching of all entityNamespaces settings

https://gerrit.wikimedia.org/r/337884