Page MenuHomePhabricator
Create Task
Maniphest T157985

Production JS error on MainPage
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

Navigate to https://en.m.wikipedia.org/wiki/Main_Page (stable, Chrome, anon)
I think this is because Page::getLeadSection returns null and this isn't handled by page issues code.

Exception in module-execute in module skins.minerva.scripts:
load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:176 TypeError: Cannot read property 'find' of null TypeError: Cannot read property 'find' of null
    at createBanner (eval at <anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:4), <anonymous>:170:495)
    at initPageIssues (eval at <anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:4), <anonymous>:171:151)
    at eval (eval at <anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:4), <anonymous>:171:568)
    at eval (eval at <anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:4), <anonymous>:171:586)
    at mw.loader.implement.mobile-frontend-console-recruit (eval at <anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:4), <anonymous>:171:591)
    at Object.<anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:161)
    at fire (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:45)
    at Object.add [as done] (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:45)
    at Object.always (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:46)
    at runScript (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:161)
logError @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:176
handler @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:154
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:45
fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:46
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:46
track @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:154
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:161
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:45
add @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:45
always @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:46
runScript @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:161
checkCssHandles @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:162
execute @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:162
handlePending @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:158
markModuleReady @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:161
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:161
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:45
add @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:45
always @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:46
runScript @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:161
checkCssHandles @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:162
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:162
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:45
fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:46
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:46
fireCallbacks @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:156
addEmbeddedCSS @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:157
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=1rfuz0b:156

Details

SubjectRepoBranchLines +/-
Make sure banner is rendered in a container elementmediawiki/extensions/MobileFrontendmaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Feb 13 2017, 5:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2017, 5:51 PM
Jdlrobson triaged this task as High priority.Feb 13 2017, 5:52 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Reading-Web-Sprint-91-🐔🍔.
Jdlrobson edited projects, added Reading-Web-Sprint-92-🍜; removed Reading-Web-Sprint-91-🐔🍔.
Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Feb 13 2017, 7:06 PM
gerritbot subscribed.Feb 13 2017, 10:14 PM

Change 337499 had a related patch set uploaded (by Bmansurov):
Make sure banner is rendered in a container element

https://gerrit.wikimedia.org/r/337499

gerritbot added a project: Patch-For-Review.Feb 13 2017, 10:14 PM
Jdlrobson edited projects, added Reading-Web-Sprint-91-🐔🍔, Unplanned-Sprint-Work; removed Reading-Web-Sprint-92-🍜.Feb 13 2017, 10:21 PM
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-91-🐔🍔 board.
gerritbot added a comment.Feb 13 2017, 10:31 PM

Change 337499 merged by jenkins-bot:
Make sure banner is rendered in a container element

https://gerrit.wikimedia.org/r/337499

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)).Feb 13 2017, 11:00 PM
Jdlrobson claimed this task.Feb 14 2017, 1:36 AM
Jdlrobson set the point value for this task to 0.5.
Jdlrobson added a subscriber: • bmansurov.

I can sign off tomorrow on https://he.m.wikipedia.org/ or https://m.mediawiki.org/wiki/MediaWiki
@bmansurov does 0.5 seem like a fair reflection of the work here?

• bmansurov added a comment.Feb 14 2017, 1:40 AM

Yes, 0.5 seems about right.

Jdlrobson removed a project: Patch-For-Review.Feb 14 2017, 1:43 AM
ovasileva moved this task from Upcoming to 2016-17 Q3 on the Web-Team-Backlog board.Feb 14 2017, 4:42 PM
Jdlrobson closed this task as Resolved.Feb 15 2017, 12:51 AM

We didn't make the branch cut apparently. I don't think it's worthy of a SWAT so I'm just going to mark as resolved since it's fixed on the beta cluster. If we get any new reports we can reconsider SWATing.

Jdlrobson merged a task: T158229: TypeError: $container is null TypeError: $container is null.Feb 15 2017, 7:27 PM
Jdlrobson added a subscriber: • Jhernandez.
• bmansurov merged a task: T157861: JS errors in MobileFrontend in Main Pages of some Wikimedia sites with $container = null in createBanner in cleanuptemplates.js.Feb 22 2017, 2:36 PM
• bmansurov added subscribers: Amire80, TheDJ, TerraCodes, Nemo_bis.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits