See T158013: EPIC: to a full-feature map visual editor

@JGirault Can you link me to a test instance or show a few screenshots that explain this a bit more? I'm having trouble following.

@Deskana, I added some screenshots to show the current lack of support and awkward experience.

My knowledge of VE is limited, so I need a little help here. @Esanders, @Jdforrester-WMF

The current node highlight is such as:

The idea here is to disable the Edit button, and add an informative message such as:

• The map is only editable with source editing because auto positioning is not yet supported by the Visual Editor.
• The map is only editable with source editing because external data sources are not yet supported by the Visual Editor.
• The map is only editable with source editing because data groups are not yet supported by the Visual Editor.

In which case the node highlight could look like :

I have a few questions:

From a UX standpoint, and according to VE patterns, is such a solution acceptable?

More technical questions:

• How to disable the Edit button?
• How to put a message in the div.ve-ui-linearContextItem-body ?
• How to disable the following CSS properties from div.ve-ui-linearContextItem-body :

overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;

(^ in other words, can I add a custom class to div.ve-ui-linearContextItem-body ?)

Thanks for your help!

From a product POV, I think we should disable unsupported modes, yes.

What you want is for the DM node to not recognise <mapframe> as an editable type by it, which means it won't load the Kartographer-specific code, so the generic extension handler will let you edit it "raw" (as wikitext) instead. I'm not sure if this is something we currently support, however – getMatchRdfaTypes is normally the method, which doesn't extend to node contents…

https://phabricator.wikimedia.org/diffusion/EKAR/browse/master/modules/ve-maps/ve.dm.MWMapsNode.js

@Esanders, could you help out?

@Esanders Can you help us with the implementation on this when you get a chance? It's a must have for us wrapping up work; see T155601 for more details.

@Esanders Is this something you or someone else in the VisualEditor team can help with? It's been nearly a month since the first request. If you can't due to time constraints that's totally understandable, and I'd like to know that so I can plan accordingly. Thanks!

Hi, sorry for missing the pings . We do something similar for references:

I'll find the parts of the code that do this, or come ask me on IRC.

You'll want to extend the ve.ui.LinearContextItem like in ve.ui.MWReferenceContextItem in the Cite extension. You can disable the edit button by adding an isEditable method to ve.dm.MWMapsNode.

In T157996#3134832, @Esanders wrote:

You'll want to extend the ve.ui.LinearContextItem like in ve.ui.MWReferenceContextItem in the Cite extension. You can disable the edit button by adding an isEditable method to ve.dm.MWMapsNode.

Thanks @Esanders, that should get me started. I'll play with that, and come back to you if I have any questions.

Change 345272 had a related patch set uploaded (by JGirault):
[mediawiki/extensions/Kartographer@master] Disable VE when features are not supported

https://gerrit.wikimedia.org/r/345272

With this patch:

Maplink not supported in VE
Mapframe not supported in VE
Mapframe supported in VE

Todo:

• Double clicking on the maplink/mapframe still opens the editing dialog.
• Also, clicking on the Edit button doesn't work, although the map should be editable.

@Esanders can you take a look at the patch, review the implementation, and help me figure out those two issues ?

Ok now only the double click on the maplink still opens the dialog. I think I have to extend ve.ui.Command and run mwMaps through this.model.isEditable...

Thanks Julien! I think the messages you added look good.

Change 345272 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Disable VE when features are not supported

https://gerrit.wikimedia.org/r/345272