Page MenuHomePhabricator
Create Task
Maniphest T158127

Catchable fatal error: Object of class __PHP_Incomplete_Class could not be converted to string in ChronologyProtector.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Started as soon as I rolled group0 forward to wmf.12. This looks similar to T157831: Fatal error: Call to undefined method __PHP_Incomplete_Class::hasReached() in /srv/mediawiki/php-master/includes/libs/rdbms/loadbalancer/LoadBalancer.php on line 494.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make ChronologyProtector::init() use instanceof instead of empty()mediawiki/corewmf/1.29.0-wmf.11+4 -1
Make ChronologyProtector::init() use instanceof instead of empty()mediawiki/coremaster+4 -1
Make ChronologyProtector::init() use instanceof instead of empty()mediawiki/corewmf/1.29.0-wmf.12+4 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Feb 14 2017, 10:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2017, 10:07 PM
Krinkle assigned this task to aaron.Feb 14 2017, 10:11 PM
Krinkle added projects: MediaWiki-libs-Rdbms, Performance-Team.
Stashbot subscribed.Feb 14 2017, 10:11 PM

Mentioned in SAL (#wikimedia-operations) [2017-02-14T22:11:48Z] <thcipriani@tin> rebuilt wikiversions.php and synchronized wikiversions files: group0 to 1.29.0-wmf.11 for T158127

Paladox triaged this task as High priority.Feb 14 2017, 10:12 PM
Paladox subscribed.

Not sure if this should be unbreak so setting it as high priority.

thcipriani raised the priority of this task from High to Unbreak Now!.Feb 14 2017, 10:14 PM
thcipriani added a parent task: T155527: MW-1.29.0-wmf.12 deployment blockers.
In T158127#3027462, @Paladox wrote:

Not sure if this should be unbreak so setting it as high priority.

Added as a blocker to 1.29.0-wmf.12 so raising to UBN

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptFeb 14 2017, 10:15 PM
gerritbot subscribed.Feb 14 2017, 10:28 PM

Change 337755 had a related patch set uploaded (by Thcipriani):
Make ChronologyProtector::init() use instanceof instead of empty()

https://gerrit.wikimedia.org/r/337755

gerritbot added a project: Patch-For-Review.Feb 14 2017, 10:28 PM
gerritbot added a comment.Feb 15 2017, 1:21 AM

Change 337755 merged by jenkins-bot:
Make ChronologyProtector::init() use instanceof instead of empty()

https://gerrit.wikimedia.org/r/337755

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-21_(1.29.0-wmf.13)).Feb 15 2017, 2:00 AM
gerritbot added a comment.Feb 15 2017, 2:12 PM

Change 337848 had a related patch set uploaded (by Hashar):
Make ChronologyProtector::init() use instanceof instead of empty()

https://gerrit.wikimedia.org/r/337848

gerritbot added a comment.Feb 15 2017, 4:58 PM

Change 337848 merged by jenkins-bot:
Make ChronologyProtector::init() use instanceof instead of empty()

https://gerrit.wikimedia.org/r/337848

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)).Feb 15 2017, 5:00 PM
Stashbot added a comment.Feb 15 2017, 5:08 PM

Mentioned in SAL (#wikimedia-operations) [2017-02-15T17:08:09Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.12/includes/libs/rdbms/ChronologyProtector.php: [[gerrit:337848|Make ChronologyProtector::init() use instanceof instead of empty()]] T158127 (duration: 00m 43s)

gerritbot added a comment.Feb 15 2017, 5:22 PM

Change 337878 had a related patch set uploaded (by Thcipriani):
Make ChronologyProtector::init() use instanceof instead of empty()

https://gerrit.wikimedia.org/r/337878

gerritbot added a comment.Feb 15 2017, 5:39 PM

Change 337878 merged by jenkins-bot:
Make ChronologyProtector::init() use instanceof instead of empty()

https://gerrit.wikimedia.org/r/337878

Stashbot added a comment.Feb 15 2017, 5:41 PM

Mentioned in SAL (#wikimedia-operations) [2017-02-15T17:41:40Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.11/includes/libs/rdbms/ChronologyProtector.php: [[gerrit:337878|Make ChronologyProtector::init() use instanceof instead of empty()]] T158127 (duration: 00m 41s)

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)).Feb 15 2017, 6:00 PM
thcipriani mentioned this in T158217: Fatal error: Call to undefined method __PHP_Incomplete_Class::asOfTime() in /srv/mediawiki/php-1.29.0-wmf.11/includes/libs/rdbms/ChronologyProtector.php on line 327.Feb 15 2017, 6:05 PM
• Gilles moved this task from Inbox, needs triage to To-do: Goals prioritized current Quarter on the Performance-Team board.Feb 15 2017, 8:48 PM
aaron closed this task as Resolved.Feb 15 2017, 9:36 PM
Krinkle renamed this task from Catchable fatal error: Object of class __PHP_Incomplete_Class could not be converted to string in /srv/mediawiki/php-1.29.0-wmf.12/includes/libs/rdbms/ChronologyProtector.php on line 124 to Catchable fatal error: Object of class __PHP_Incomplete_Class could not be converted to string in ChronologyProtector.php.Feb 15 2017, 9:55 PM
Krinkle removed a project: Patch-For-Review.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits