Page MenuHomePhabricator
Create Task
Maniphest T158144

Cleanup new header cache artifacts
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The new header HTML is riding the train and will be deployed as part of 1.29.0-wmf.13 which will roll out from the 21st February.

So as soon as that branch has been cut, you can remove any FIXMEs associated with T157987 and clearing the cache. They should relate to FIXMEs added in {{8180f4ab5e8f5fea6a0e7d6ad3da1db276b3149b}} and {{If1b014feac263ac5632cbbf797f597e43cf74868}} and are (but may not be limited to) the following:

resources/mobile.search/SearchOverlay.less
132:// Please remove entire block when the cache has cleared for T157987.

resources/skins.minerva.base.styles/ui.less
123:	// FIXME: form selector is only necessary until cache has cleared. Please remove promptly (T157987)
326:	// FIXME: Remove when cache has cleared (T157987)

Please ensure that any styles relating to feature-header-v1 and feature-header-v2 are not removed at this time. These are captured in T156796.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+0 -7Hygiene: Remove unused main class declaration
mediawiki/extensions/MobileFrontendmaster+0 -5Hygiene: Remove unused header > .main declaration
mediawiki/extensions/MobileFrontendmaster+0 -37Cleanup header cache artifacts
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Feb 15 2017, 1:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2017, 1:02 AM
Jdlrobson added projects: Readers-Web-Backlog, Technical-Debt.Feb 15 2017, 1:03 AM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-92-🍜 board.Feb 15 2017, 1:06 AM
Jdlrobson moved this task from To Do to Blocked Externally on the Reading-Web-Sprint-92-🍜 board.
ovasileva moved this task from Incoming to Upcoming on the Readers-Web-Backlog board.Feb 15 2017, 3:51 PM
ovasileva triaged this task as High priority.Feb 15 2017, 6:53 PM
ovasileva set the point value for this task to 1.
ovasileva moved this task from Upcoming to 2016-17 Q3 on the Readers-Web-Backlog board.Feb 17 2017, 12:03 PM
ovasileva moved this task from Blocked Externally to To Do on the Reading-Web-Sprint-92-🍜 board.Feb 21 2017, 6:08 PM
phuedx updated the task description. (Show Details)Feb 21 2017, 6:15 PM
phuedx added a subscriber: phuedx.

The -wmf.13 branch hasn't been cut yet. It should be done at 8 PM UTC. Once it has been, then this task can be worked on.

phuedx moved this task from To Do to Blocked Externally on the Reading-Web-Sprint-92-🍜 board.Feb 21 2017, 6:19 PM
phuedx moved this task from Blocked Externally to To Do on the Reading-Web-Sprint-92-🍜 board.Feb 22 2017, 3:02 PM

The -wmf.13 branch was cut yesterday at ~8 PM UTC.

pmiazga claimed this task.Feb 22 2017, 6:05 PM
pmiazga moved this task from To Do to Doing on the Reading-Web-Sprint-92-🍜 board.
gerritbot added a subscriber: gerritbot.Feb 22 2017, 6:41 PM

Change 339233 had a related patch set uploaded (by Pmiazga):
Cleanup header cache artifacts

https://gerrit.wikimedia.org/r/339233

gerritbot added a project: Patch-For-Review.Feb 22 2017, 6:41 PM
phuedx moved this task from Doing to Needs Code Review on the Reading-Web-Sprint-92-🍜 board.Feb 23 2017, 9:35 AM
phuedx added a comment.Feb 23 2017, 9:46 AM

^ Jenkins now smiles upon rEMFR9fbeead90e1a: Cleanup header cache artifacts.

gerritbot added a comment.Feb 24 2017, 6:05 PM

Change 339233 merged by jenkins-bot:
Cleanup header cache artifacts

https://gerrit.wikimedia.org/r/339233

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)).Feb 24 2017, 7:00 PM
gerritbot added a comment.Feb 24 2017, 7:28 PM

Change 339682 had a related patch set uploaded (by Pmiazga):
Hygiene: Remove unused main class declaration

https://gerrit.wikimedia.org/r/339682

gerritbot added a comment.Feb 24 2017, 7:28 PM

Change 339683 had a related patch set uploaded (by Pmiazga):
Hygiene: Remove unused header > .main declaration

https://gerrit.wikimedia.org/r/339683

gerritbot added a comment.Feb 24 2017, 7:30 PM

Change 339682 abandoned by Pmiazga:
Hygiene: Remove unused main class declaration

Reason:
duplicate

https://gerrit.wikimedia.org/r/339682

gerritbot added a comment.Feb 27 2017, 10:42 PM

Change 339682 restored by Pmiazga:
Hygiene: Remove unused main class declaration

https://gerrit.wikimedia.org/r/339682

gerritbot added a comment.Feb 27 2017, 10:45 PM

Change 339683 abandoned by Pmiazga:
Hygiene: Remove unused header > .main declaration

Reason:
incorrect commit (I forgot to do --amend)

https://gerrit.wikimedia.org/r/339683

pmiazga moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-92-🍜 board.Feb 27 2017, 11:38 PM
phuedx reassigned this task from pmiazga to bmansurov.Feb 28 2017, 10:53 AM
phuedx added subscribers: bmansurov, pmiazga.

This is a technical task. Over to you @bmansurov!

bmansurov closed this task as Resolved.Feb 28 2017, 9:21 PM
bmansurov removed bmansurov as the assignee of this task.

Although some open patches link to this task, they are not directly related to what's being asked in the task description. The FIXME's have been removed, so resolving the task.

gerritbot added a comment.Mar 10 2017, 9:35 PM

Change 339682 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend] Hygiene: Remove unused main class declaration

https://gerrit.wikimedia.org/r/339682

ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)); removed MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)).Mar 10 2017, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL