Page MenuHomePhabricator

Discuss labsdb visibility of rev_text_id and ar_comment
Open, Needs TriagePublic

Description

In labsd:

  • revision.rev_text_id is 0 while archive.archive_text_id has values - This looks like a sanitization bug (rev_text_id is public and available in dumps).
  • archive.ar_comment is set to NULL at view creation [1], while only nullified in revision view according to the deleting flag [2] - I suggest the archive behavior to mimic the revision one.

[1] https://github.com/wikimedia/operations-puppet/blob/production/modules/role/templates/labs/db/views/maintain-views.yaml#L204
[2] https://github.com/wikimedia/operations-puppet/blob/production/modules/role/templates/labs/db/views/maintain-views.yaml#L330

Event Timeline

This seems like background work related to labs import rather than a task per se, moving to radar.

Ping @JAllemandou Did you talk with labs team about this?

I discussed this with @ArielGlenn. He told me he wouold investigate.
Ping @ArielGlenn?

After my initial ping, I dropped this ball. Picking it back up again.

If I remember correctly the ar_comment was visible in labsdb before moving to separate comment table.

I think it would be good that the comments would be still visible because it is one of the rare places where to get data about deletion reasons. In example how many articles were deleted because notability, were there notability discussion and how many days the average discussion, did the creator of the page participate to discussion etc.