Page MenuHomePhabricator

"Visible To" should not display "Spaces" dropdown if user can only access the public S1 space
Open, Needs TriagePublic

Description

Our "Visible To" interface looks like this:

The first part says the ticket is public, but in this case it actually isn't. Frankly I've never understood what the first select list is for, but I've never used it and it doesn't seem to be helpful. Whenever I'm training new hires I tell them to just ignore the first select list and use the second.

What is the first select list actually for? Do we need it? If so, can the options be changed to be more accurate/less confusing?

Event Timeline

kaldari created this task.Feb 15 2017, 7:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2017, 7:08 PM

The first part is the Space the task is in.
Spaces are 'stronger' than any potential custom policies in the second dropdown.
And yes we need Spaces. :)
Any ideas what would be less confusing?

Restricted Application added a project: Upstream. · View Herald TranscriptFeb 15 2017, 7:40 PM
Aklapper renamed this task from "Visible To" interface is confusing to "Visible To" interface is confusing: Spaces dropdown (e.g. saying "S1: Public") and second dropdown (e.g. saying "Custom Policy").Feb 15 2017, 7:41 PM

If we're using Spaces for real things now, can we remove the S3 "Testing space", and then make sure the dropdown is not shown if the user doesn't have the right to access any of the restricted spaces?

If we're using Spaces for real things now, can we remove the S3 "Testing space", and then make sure the dropdown is not shown if the user doesn't have the right to access any of the restricted spaces?

I've archived S3. The latter should be the case already.

Thanks. But nope:

Aklapper renamed this task from "Visible To" interface is confusing: Spaces dropdown (e.g. saying "S1: Public") and second dropdown (e.g. saying "Custom Policy") to "Visible To" should not display "Spaces" dropdown if user can only access the public S1 space.Feb 16 2017, 5:02 PM

I still get the spaces interface (like matmarex), even though I can only see 1 space.

According to our documentation, that shouldn't be the case.

Please provide URLs to reproduce.

Please provide URLs to reproduce.

(That was my volunteer account not being able to reproduce in some places.)

Aklapper added a comment.EditedFeb 21 2017, 10:29 PM

(For the records, with my "default" @Malyacko account I do not see any "Visible To" dropdowns on https://phabricator.wikimedia.org/maniphest/task/edit/158226/ )