Page MenuHomePhabricator
Create Task
Maniphest T158262

Error "Please enter a comment below" from trying to add a blank new section is confusing for NWE users
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Click on "New Section" tab
  2. Type something for the heading

3.Click on "Save Changes" button

  1. Click on the "Save Changes" button on the save dialog

Observed Result:
The section heading does not get saved, shows a dialog saying "Something went wrong, Please enter a comment below"

Screen Shot 2017-02-15 at 3.46.24 PM.png (573×1 px, 225 KB)

Details

SubjectRepoBranchLines +/-
Fix missingcommenttext message to be more useful in different page layoutsmediawiki/coremaster+1 -1
Customize query in gerrit

Event Timeline

Ryasmeen created this task.Feb 15 2017, 11:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2017, 11:57 PM
Jdforrester-WMF renamed this task from Cannot add a new section, getting error "Please enter a comment below" while trying to save the page to Error "Please enter a comment below" from trying to add a blank new section is confusing for NWE users.Feb 27 2017, 7:15 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF added a project: VisualEditor-MediaWiki-2017WikitextEditor.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
• Deskana claimed this task.Oct 18 2017, 2:13 PM
• Deskana subscribed.

This is the "missingcommenttext" message in MediaWiki core, which was written assuming a certain page layout. The "below" in the message is quite redundant.

gerritbot subscribed.Oct 18 2017, 2:15 PM

Change 384981 had a related patch set uploaded (by Deskana; owner: Deskana):
[mediawiki/core@master] Fix missingcommenttext message to be more useful in different page layouts

https://gerrit.wikimedia.org/r/384981

gerritbot added a project: Patch-For-Review.Oct 18 2017, 2:15 PM
gerritbot added a comment.Oct 18 2017, 2:24 PM

Change 384981 merged by jenkins-bot:
[mediawiki/core@master] Fix missingcommenttext message to be more useful in different page layouts

https://gerrit.wikimedia.org/r/384981

• Deskana closed this task as Resolved.Oct 18 2017, 2:25 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 18 2017, 2:25 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 18 2017, 3:00 PM
Ryasmeen edited projects, added Verified; removed Patch-For-Review.Oct 18 2017, 8:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL