Page MenuHomePhabricator
Create Task
Maniphest T158284

CollaborationKitImage: make non-square images center correctly in displayed square for square applications (ToC, list images)
Closed, ResolvedPublic
Actions

Description

Does this:

image.png (327×443 px, 41 KB)

Should be more like this:

image.png (303×327 px, 41 KB)

vertical-align: middle is applied, but it doesn't do anything about this.

Details

SubjectRepoBranchLines +/-
Centering non-square imagesmediawiki/extensions/CollaborationKitmaster+75 -32
Customize query in gerrit

Related Objects

Event Timeline

Isarra created this task.Feb 16 2017, 7:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2017, 7:58 AM
Harej claimed this task.Feb 18 2017, 6:48 AM
Harej moved this task from Release blockers to In Progress on the MediaWiki-extensions-CollaborationKit board.
gerritbot subscribed.Feb 18 2017, 11:33 AM

Change 338528 had a related patch set uploaded (by Harej):
Centering non-square images

https://gerrit.wikimedia.org/r/338528

gerritbot added a project: Patch-For-Review.Feb 18 2017, 11:34 AM
Harej mentioned this in rECKT6d68d306c1b7: Centering non-square images.Feb 18 2017, 11:34 AM
Harej mentioned this in rECKT61a2a84617d8: Centering non-square images.Feb 22 2017, 3:51 AM
Harej mentioned this in rECKT6def52c6399c: Centering non-square images.Feb 22 2017, 4:20 AM
Harej mentioned this in rECKTca7e3b8ae410: Centering non-square images.Feb 23 2017, 10:08 AM
Harej mentioned this in rECKTf3aff9ef56d7: Centering non-square images.Feb 24 2017, 3:24 AM
Harej mentioned this in rECKTb2c232441f83: Centering non-square images.Feb 25 2017, 7:31 AM
Harej mentioned this in rECKT880c8dd21652: Centering non-square images.Feb 25 2017, 7:35 AM
Harej mentioned this in rECKTc5b960bdefd3: Centering non-square images.Feb 25 2017, 10:02 AM
Harej mentioned this in rECKT8ee441839192: Centering non-square images.Feb 25 2017, 7:02 PM
Harej mentioned this in rECKT490752602170: Centering non-square images.Feb 25 2017, 8:30 PM
Harej mentioned this in rECKTf36cff14eeb6: Centering non-square images.
Harej mentioned this in rECKTe2c812ea3149: Centering non-square images.Feb 26 2017, 6:34 PM
Harej mentioned this in rECKTd393523b5ac8: Centering non-square images.Feb 26 2017, 7:38 PM
Harej mentioned this in rECKTf026f14bd282: Centering non-square images.Feb 26 2017, 7:40 PM
Harej mentioned this in rECKT0b2f6c7ce500: Centering non-square images.Feb 26 2017, 7:46 PM
Harej mentioned this in rECKT731098d54289: Centering non-square images.Feb 26 2017, 9:36 PM
Harej mentioned this in rECKT256ca4760e45: Centering non-square images.Feb 28 2017, 10:28 PM
gerritbot added a comment.Feb 28 2017, 10:38 PM

Change 338528 merged by jenkins-bot:
Centering non-square images

https://gerrit.wikimedia.org/r/338528

Harej moved this task from In Progress to Done on the MediaWiki-extensions-CollaborationKit board.Feb 28 2017, 10:39 PM
Harej closed this task as Resolved.Mar 1 2017, 7:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL