Page MenuHomePhabricator

VisualEditor Cite dialog, when Ctrl+Enter is pressed, inserts a newline before closing the dialog
Closed, ResolvedPublic1 Story Points

Description

In VisualEditor, when the Cite dialog is in use ("Basic Form"), the keystroke equivalent Ctrl+Enter is supposed to close the dialog. It does close the dialog, but it also inserts a newline character into the citation at the cursor position. That insertion should not happen.

Verified on Wikipedia today in the latest Firefox on Windows 7 Professional, and on a MediaWiki 1.28 server using Linux Chrome. The bug is present in MediaWiki 1.28.1 and 1.29.0-wmf.11 (fa8cb27).

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterUpdate VE core submodule to master (813c586a6)
VisualEditor/VisualEditor : masterLinearEnterKeyDownHandler: abort if in dialog and ctrl/cmd held

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2017, 4:15 PM

Change 338994 had a related patch set uploaded (by DLynch):
LinearEnterKeyDownHandler: abort if in dialog and ctrl/cmd held

https://gerrit.wikimedia.org/r/338994

Change 338994 merged by jenkins-bot:
LinearEnterKeyDownHandler: abort if in dialog and ctrl/cmd held

https://gerrit.wikimedia.org/r/338994

Change 339481 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (813c586a6)

https://gerrit.wikimedia.org/r/339481

Change 339481 merged by jenkins-bot:
Update VE core submodule to master (813c586a6)

https://gerrit.wikimedia.org/r/339481

Jdforrester-WMF closed this task as Resolved.Feb 23 2017, 8:08 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.