Page MenuHomePhabricator
Create Task
Maniphest T158460

Replace AJAX Flash.js in SocialProfile and AJAX loaders across other social tool extensions with OOUI ProgressBarWidget
Open, Needs TriagePublic
Actions

Description

Flash.js will check whether or not the user's side has Flash supported to check whether or not to use a .gif or .swf. There's already logic written in OOUI for progress loading as a ProgressBarWidget, so ideally we should use that instead (which will also standardize part of the current UI in SocialProfile). Currently this is used for PollNY, PictureGame, QuizGame, and FanBoxes.

Details

SubjectRepoBranchLines +/-
Remove commented out reference to 'ajax-loader.gif'mediawiki/extensions/PictureGamemaster+1 -2
Remove commented out reference to 'ajax-loader.gif'mediawiki/extensions/PollNYmaster+2 -3
Remove unused file, 'ajax-loader.gif'mediawiki/extensions/SocialProfilemaster+0 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

SamanthaNguyen created this task.Feb 18 2017, 2:13 AM
SamanthaNguyen moved this task from Backlog to Feedback on the SocialProfile board.Feb 18 2017, 2:30 AM
SamanthaNguyen renamed this task from Replace AJAX Flash.js with OOUI ProgressBarWidget to Replace AJAX Flash.js in SocialProfile and AJAX loaders across other social tool extensions with OOUI ProgressBarWidget.Feb 18 2017, 3:37 AM
SamanthaNguyen updated the task description. (Show Details)

Some more interesting notes, FanBoxes doesn't reference the .swf file. Also this is a compiled, more human-readable list that I converted from a grep for interests of what lines reference each files. Also, it looks like the only references of ajax-loader.gif are actually commented out references, so it should be safe to delete that file.

SamanthaNguyen updated the task description. (Show Details)Feb 18 2017, 3:38 AM
SamanthaNguyen added projects: FanBoxes, PollNY, PictureGame, QuizGame.Feb 18 2017, 3:41 AM
gerritbot subscribed.Feb 18 2017, 4:02 AM

Change 338511 had a related patch set uploaded (by SamanthaNguyen):
Remove unused file, 'ajax-loader.gif`

https://gerrit.wikimedia.org/r/338511

gerritbot added a project: Patch-For-Review.Feb 18 2017, 4:02 AM
gerritbot added a comment.Feb 18 2017, 4:05 AM

Change 338512 had a related patch set uploaded (by SamanthaNguyen):
Remove commented out reference to 'ajax-loader.gif'

https://gerrit.wikimedia.org/r/338512

gerritbot added a comment.Feb 18 2017, 4:09 AM

Change 338513 had a related patch set uploaded (by SamanthaNguyen):
Remove commented out reference to 'ajax-loader.gif'

https://gerrit.wikimedia.org/r/338513

gerritbot added a comment.Feb 18 2017, 4:35 AM

Change 338511 merged by jenkins-bot:
Remove unused file, 'ajax-loader.gif'

https://gerrit.wikimedia.org/r/338511

gerritbot added a comment.Feb 18 2017, 4:35 AM

Change 338512 merged by jenkins-bot:
Remove commented out reference to 'ajax-loader.gif'

https://gerrit.wikimedia.org/r/338512

gerritbot added a comment.Feb 18 2017, 4:35 AM

Change 338513 merged by jenkins-bot:
Remove commented out reference to 'ajax-loader.gif'

https://gerrit.wikimedia.org/r/338513

SamanthaNguyen removed a project: Patch-For-Review.Feb 18 2017, 4:42 AM
Volker_E moved this task from Unsorted to Conversion to OOUI on the UI-Standardization board.Feb 18 2017, 10:54 PM
SamanthaNguyen added a parent task: T100025: Reduce Social Tools code duplication.Feb 26 2017, 6:33 AM
SamanthaNguyen updated the task description. (Show Details)Feb 28 2017, 5:00 AM
SamanthaNguyen moved this task from Backlog to Feedback on the FanBoxes board.
SamanthaNguyen moved this task from Backlog to Feedback on the QuizGame board.Mar 14 2017, 7:53 PM
SamanthaNguyen moved this task from Backlog to Feedback on the PictureGame board.May 29 2017, 2:17 AM
ashley updated the task description. (Show Details)Nov 6 2017, 12:39 PM
SamanthaNguyen unsubscribed.Jun 30 2018, 7:22 PM
Volker_E removed a project: UI-Standardization.Feb 5 2024, 4:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL