Previously, users needed to be manually given the shell right, and the shellmanagers group had the right do so now. This is now handled automatically: When a user is added to a Labs project, the shell right is given. So the shellmanagers group makes no sense more and should be removed.
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | MarcoAurelio | T56697 add useful content to Wikitech:Shell | |||
Resolved | MarcoAurelio | T158417 Group messages for Wikitech | |||
Declined | None | T158416 migrateUserGroups.php after T158039 | |||
Declined | None | T158039 Wikitech: rename 'shellmanagers' to 'shellmanager' for consistency | |||
Resolved | MarcoAurelio | T158516 Decide which group(s) will be able to manage 'shell' on wikitech | |||
Resolved | MarcoAurelio | T158482 Remove shellmanagers group on wikitech | |||
Resolved | MarcoAurelio | T158515 Remove 'shellmanagers' rights from all users before removing the group on Wikitech |
Event Timeline
If this is right, then I shall amend a couple of patches where this usergroup is present.
The automatic group management for shell was added in rEOST1d147bf7c32a: Revert "Revert "Automatically add to shell group when adding to a project"" for T97334: Grant shell user right with project memberships and remove autocreation of shell requests. The shell group itself is needed, but shellmanagers is not.
@bd808 I understand. Is the process at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/Access_Request still needed then?
Thanks for the explanation, this is helpful. I'll amend my previous patches removing references to the shellmanagers, etc.
Regards.
Change 338632 had a related patch set uploaded (by MarcoAurelio):
Removing the 'shellmanagers' group from Wikitech
Yes, that process is for getting membership in the Tools project. We have been talking a bit about changing the exact mechanics of how that process works (T72625), but it is still needed.
Change 338751 had a related patch set uploaded (by MarcoAurelio):
Configuration changes for wikitech.wikimedia.org
Patches submitted to remove the shellmanagers group and to grant the ability to add/remove the shell usergroup to Wikitech bureaucrats.
Change 338751 merged by jenkins-bot:
Configuration changes for wikitech.wikimedia.org
Mentioned in SAL (#wikimedia-operations) [2017-02-22T19:14:36Z] <thcipriani@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:338751|Configuration changes for wikitech.wikimedia.org]] T158516 T158554 T158482 (duration: 00m 40s)
Change 338632 merged by jenkins-bot:
Removing the 'shellmanagers' group from Wikitech
Mentioned in SAL (#wikimedia-operations) [2017-02-22T19:34:34Z] <thcipriani@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:338632|Removing the "shellmanagers" group from Wikitech]] T158482 (duration: 00m 49s)
Change 339238 had a related patch set uploaded (by MarcoAurelio):
Follow-up I5edebdff
Mentioned in SAL (#wikimedia-operations) [2017-02-22T19:45:44Z] <thcipriani@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:339238|Finish removing "shellmanagers" on Wikitech]] T158482 (duration: 00m 40s)