MiniInviteHooks::createOpinionCheck if expression in a foreach loop is site-specific
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	SamanthaNguyen
	Feb 18 2017, 6:51 PM

Description

@ashley should be able to know more about this.

MiniInvite/InviteFriendOnEdit.php

foreach ( $res as $row ) {
	// @todo FIXME: this is way too site-specific...
	if ( $wgLang->uc( $row->cl_to ) == 'OPINIONS' ) {
		$_SESSION['new_opinion'] = $title->getText();
	}
}

Related Objects

Mentioned Here: rEMIV31091ae2574f: Some long overdue cleanup and modernization

Event Timeline

SamanthaNguyen created this task.Feb 18 2017, 6:51 PM

SamanthaNguyen moved this task from Backlog to Feedback on the MiniInvite board.

SamanthaNguyen unsubscribed.Jun 30 2018, 8:07 PM

ashley moved this task from Backlog to MiniInvite on the Social-Tools board.Jan 4 2020, 11:59 AM

The condition was changed in MiniInvite version 2.4.2 (31091ae2574fa3b8229507762931bd5d5ca258cf) from "is the given page in Category:Opinions?" to "is the given page in the blog namespace (NS_BLOG)?", which resolves this task at least in some manner.

MiniInviteHooks::createOpinionCheck if expression in a foreach loop is site-specificClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

MiniInviteHooks::createOpinionCheck if expression in a foreach loop is site-specific
Closed, ResolvedPublic
Actions