Phase out jobs puppet-validate and puppetlint-strict jobs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Feb 20 2017, 9:52 AM

Description

We are phasing out the pplint-HEAD and erblint-HEAD jobs (T154894) in favor of using the ruby gem puppet-syntax.

We can also phase out the puppet-validate jobs which really just:

find . -type f -name '*.pp' -print0 | xargs -0 puppet parser validate

That is covered by the puppet-syntaxgem.

jjb/integration.yaml:194:     - '{name}-puppet-validate'
jjb/job-templates.yaml:367:    name: '{name}-puppet-validate'
jjb/mediawiki-misc.yaml:34:     - '{name}-puppet-validate'
jjb/translatewiki.yaml:3:    name: 'translatewiki-puppet-validate'
jjb/translatewiki.yaml:35:     - translatewiki-puppet-validate
tests/test_zuul_scheduler.py:322:            '.*-puppet-validate',
zuul/layout.yaml:705:  - name: 'integration-config-puppet-validate'
zuul/layout.yaml:1300:      - integration-config-puppet-validate
zuul/layout.yaml:1307:      - integration-config-puppet-validate
zuul/layout.yaml:2103:      - mediawiki-vagrant-puppet-validate
zuul/layout.yaml:2106:      - mediawiki-vagrant-puppet-validate
zuul/layout.yaml:2109:      - mediawiki-vagrant-puppet-validate
zuul/layout.yaml:2484:      - translatewiki-puppet-validate
zuul/layout.yaml:2488:      - translatewiki-puppet-validate
zuul/layout.yaml:2493:      - translatewiki-puppet-validate

Ditto for puppetlint-struct jobs.

Details

Subject	Repo	Branch	Lines +/-
Tweak Zuul files filter for translatewiki-rake-jessie	integration/config	master	+6 -0
Remove '{name}-puppetlint-strict'	integration/config	master	+0 -21
translatewiki: use rake as an entry point	integration/config	master	+2 -28
Lint puppet material using rake	translatewiki	master	+44 -0
Experimental job translatewiki-rake-jessie	integration/config	master	+3 -0
Clean out puppet-validate leftover	integration/config	master	+1 -23
Use puppet-syntax to check puppet manifests	integration/config	master	+24 -3

Customize query in gerrit

Related Objects

Mentioned Here: T154894: Phase out jobs "pplint-HEAD" and "erblint-HEAD"

Event Timeline

hashar created this task.Feb 20 2017, 9:52 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2017, 9:52 AM

Paladox subscribed.Feb 20 2017, 11:02 AM

Change 338746 had a related patch set uploaded (by Hashar):
Use puppet-syntax to check puppet manifests

https://gerrit.wikimedia.org/r/338746

gerritbot added a project: Patch-For-Review.Feb 20 2017, 11:31 AM

Change 338746 merged by jenkins-bot:
Use puppet-syntax to check puppet manifests

https://gerrit.wikimedia.org/r/338746

For mediawiki/vagrant there is also changes made for T154894:

https://gerrit.wikimedia.org/r/#/c/337858/
https://gerrit.wikimedia.org/r/#/c/338415/

Change 339257 had a related patch set uploaded (by Hashar):
Clean out puppet-validate leftover

https://gerrit.wikimedia.org/r/339257

Change 339257 merged by jenkins-bot:
Clean out puppet-validate leftover

https://gerrit.wikimedia.org/r/339257

What is left to migrate is the translatewiki repo which has the puppet stuff in a sub directory.

Change 339294 had a related patch set uploaded (by Hashar):
Lint puppet material using rake

https://gerrit.wikimedia.org/r/339294

Change 339299 had a related patch set uploaded (by Hashar):
Experimental job translatewiki-rake-jessie

https://gerrit.wikimedia.org/r/339299

Change 339299 merged by jenkins-bot:
Experimental job translatewiki-rake-jessie

https://gerrit.wikimedia.org/r/339299

Change 339294 merged by jenkins-bot:
Lint puppet material using rake

https://gerrit.wikimedia.org/r/339294

Change 340089 had a related patch set uploaded (by Hashar):
translatewiki: use rake as an entry point

https://gerrit.wikimedia.org/r/340089

hashar renamed this task from Phase out jobs puppet-validate jobs to Phase out jobs puppet-validate and puppetlint-strict jobs.Feb 27 2017, 9:25 AM

hashar updated the task description. (Show Details)

Change 340090 had a related patch set uploaded (by Hashar):
Remove '{name}-puppetlint-strict'

https://gerrit.wikimedia.org/r/340090

Change 340089 merged by jenkins-bot:
translatewiki: use rake as an entry point

https://gerrit.wikimedia.org/r/340089

Change 340090 merged by jenkins-bot:
Remove '{name}-puppetlint-strict'

https://gerrit.wikimedia.org/r/340090

All migrated :}

Change 340092 had a related patch set uploaded (by Hashar):
Tweak Zuul files filter for translatewiki-rake-jessie

https://gerrit.wikimedia.org/r/340092

Change 340092 merged by jenkins-bot:
Tweak Zuul files filter for translatewiki-rake-jessie