Enhance debian-glue job packages validation
Open, LowPublic
Actions

Assigned To

None

Authored By

	hashar
	Feb 20 2017, 11:39 AM

Description

From a chat with @Volans

We already run linter, and there are artifcats from it's output but it's not shown in the console output so might be overlooked/missed.

https://gerrit.wikimedia.org/r/338752 debian-glue: only lintian against *.changes

Another useful output is: debc ${package_name}.changes to see the compiled dependencies, and all the files and directories installed by the package. See also: https://www.debian.org/doc/manuals/maint-guide/checkit.en.html

https://gerrit.wikimedia.org/r/338760 debian-glue: add debc to dump packages content

Regarding debc seems that they have already a script scripts/jdg-debc upstream that we could use. Done by 8a243939c57c17a205f1e32b999dd84b62e7c1b2

Another couple of enhancement that could be done for lintian, looking at the source code at https://github.com/mika/jenkins-debian-glue/blob/16f0ba5565435e12cb211c686bd5a49cb073252e/scripts/lintian-junit-report are:

pass the '-w', '--warnings' option to show also lintian warnings
pass the lintian -I option to show also the info messages, seems that could be done with --lintian-opt=-I
it might make sense to tee the output of lintian to the console either as is or without the --info option that shows the reasoning behind each error/warning/info line, reducing its size.

The automatic generated changelog version actually creates spurious linter errors in lintian-binary.txt

P4949 spurious lintian errors 2N: 3N: 4N: 5N: 6N: 7N: 8N: 9N: 10N: 11N: 12N: 13N: 14N: 15N: 16W: 17N: 18N: 19N: 20N: 21N: 22N: 23N: 24N: 25N: 26N: 27N: 28N: 29N: 30N: 31N: 32N: 33N: 34N: 35N: 36W: 37N: 38N: 39N: 40N: 41N: 42N: 43N: 44N: 45N: 46N: 47N: 48N: 49N: 50N: 51N: 52N: 53N: 54N: 55N: due to debian-glue

1	W: cumin source: binary-nmu-debian-revision-in-source 0.0.1-1+0~20170218004036.670+jessie+wikimedia~1.gbpfd657d The version number of your source package ends in +b and a number or has a Debian revision containing three parts. These version numbers are used by binary NMUs and should not be used as the source version. (The +b form is the current standard; the three-part version number now obsolete.) Refer to Debian Developer's Reference section 5.10.2.1 (Recompilation or binary-only NMU) for details. Severity: normal, Certainty: certain Check: fields, Type: binary, udeb, source cumin source: changelog-should-mention-nmu When you NMU a package, that fact should be mentioned on the first line in the changelog entry. Use the words "NMU" or "Non-maintainer upload" (case insensitive). Maybe you didn't intend this upload to be a NMU, in that case, please double-check that the most recent entry in the changelog is byte-for-byte identical to the maintainer or one of the uploaders. If this is a local package (not intended for Debian), you can suppress this warning by putting "local" in the version number or "local package" on the first line of the changelog entry. Refer to Debian Developer's Reference section 5.11.3 (Using the DELAYED/ queue) for details. Severity: normal, Certainty: certain Check: nmu, Type: source cumin source: source-nmu-has-incorrect-version-number 0.0.1-1+0~20170218004036.670+jessie+wikimedia~1.gbpfd657d A source NMU should have a Debian revision of "-x.x" (or "+nmuX" for a native package). This is to prevent stealing version numbers from the maintainer. Maybe you didn't intend this upload to be a NMU, in that case, please double-check that the most recent entry in the changelog is byte-for-byte identical to the maintainer or one of the uploaders. If this is a local package (not intended for Debian), you can suppress this warning by putting "local" in the version number or "local package" on the first line of the changelog entry. Refer to Debian Developer's Reference section 5.11.2 (NMUs and debian/changelog) for details. Severity: normal, Certainty: certain Check: nmu, Type: source

W: cumin source: binary-nmu-debian-revision-in-source 0.0.1-1+0~20170218004036.670+jessie+wikimedia~1.gbpfd657d The version number of your source package ends in +b and a number or has a Debian revision containing three parts. These version numbers are used by binary NMUs and should not be used as the source version. (The +b form is the current standard; the three-part version number now obsolete.) Refer to Debian Developer's Reference section 5.10.2.1 (Recompilation or binary-only NMU) for details. Severity: normal, Certainty: certain Check: fields, Type: binary, udeb, source cumin source: changelog-should-mention-nmu When you NMU a package, that fact should be mentioned on the first line in the changelog entry. Use the words "NMU" or "Non-maintainer upload" (case insensitive). Maybe you didn't intend this upload to be a NMU, in that case, please double-check that the most recent entry in the changelog is byte-for-byte identical to the maintainer or one of the uploaders. If this is a local package (not intended for Debian), you can suppress this warning by putting "local" in the version number or "local package" on the first line of the changelog entry. Refer to Debian Developer's Reference section 5.11.3 (Using the DELAYED/ queue) for details. Severity: normal, Certainty: certain Check: nmu, Type: source cumin source: source-nmu-has-incorrect-version-number 0.0.1-1+0~20170218004036.670+jessie+wikimedia~1.gbpfd657d A source NMU should have a Debian revision of "-x.x" (or "+nmuX" for a native package). This is to prevent stealing version numbers from the maintainer. Maybe you didn't intend this upload to be a NMU, in that case, please double-check that the most recent entry in the changelog is byte-for-byte identical to the maintainer or one of the uploaders. If this is a local package (not intended for Debian), you can suppress this warning by putting "local" in the version number or "local package" on the first line of the changelog entry. Refer to Debian Developer's Reference section 5.11.2 (NMUs and debian/changelog) for details. Severity: normal, Certainty: certain Check: nmu, Type: source

Details

	Subject	Repo	Branch	Lines +/-
	debian-glue: add debc to dump packages content	integration/config	master	+4 -1
	debian-glue: only lintian against *.changes	integration/config	master	+5 -6

Customize query in gerrit

Related Objects

Mentioned Here: rCICF8a243939c57c: debian-glue: add debc to dump packages content
P4949 spurious lintian errors due to debian-glue

Event Timeline

hashar created this task.Feb 20 2017, 11:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2017, 11:39 AM

pass the '-w', '--warnings' option to show also lintian warnings
pass the lintian -I option to show also the info messages, seems that could be done with --lintian-opt=-I
it might make sense to tee the output of lintian to the console either as is or without the --info option that shows the reasoning behind each error/warning/info line, reducing its size.

Regarding debc seems that they have already a script scripts/jdg-debc upstream that we could use.