Page MenuHomePhabricator
Create Task
Maniphest T158610

BookletLayout/booklet dialog: Safari 10/OSX doesn't show vertical scrollbar when system is set to always show scrollbars
Closed, ResolvedPublic
Actions

Assigned To
Volker_E
Authored By
Volker_E
Feb 21 2017, 12:52 AM
Tags
Referenced Files
F5736310: Screen Shot 2017-02-21 at 1.34.45 PM.png
Feb 21 2017, 8:06 AM
F5736304: Screen Shot 2017-02-21 at 1.34.25 PM.png
Feb 21 2017, 8:06 AM
F5730753: T158610 Booklet dialog scrollbar missing in Saf - OOjs UI Demos 2017-02-20.png
Feb 21 2017, 12:54 AM
Subscribers
Aklapper
• Deskana
• Elitre
Esanders
Jdforrester-WMF
matmarex
• Prtksxna
Volker_E

Description

As of v0.19.2, Safari 10 doesn't show vertical scrollbar in BookletLayout (in contrast to ”Process dialog (medium, long)“ for example).

T158610 Booklet dialog scrollbar missing in Saf - OOjs UI Demos 2017-02-20.png (301×503 px, 42 KB)

Expected result:
Scrollbar shown as indicator that there's overflowing content.

Details

SubjectRepoBranchLines +/-
PanelLayout: Remove buggy `translateZ` performance hackoojs/uimaster+0 -17
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Feb 21 2017, 12:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2017, 12:52 AM
Volker_E updated the task description. (Show Details)Feb 21 2017, 12:54 AM
Volker_E added subscribers: matmarex, Jdforrester-WMF, • Prtksxna.
matmarex added a comment.Feb 21 2017, 2:34 AM

I think OS X doesn't normally display scrollbars at all, unless you have a mouse connected.

SamanthaNguyen added a project: Browser-Support-Apple-Safari.Feb 21 2017, 2:51 AM
Volker_E added a comment.Feb 21 2017, 5:15 AM

There's a special treatment of scrollbar visibility on OS X, that's true. The issue is the inconsistency between browsers and dialogs in Safari though. As far as I understood, Chrome should behave similar in visibility.

• Prtksxna added a comment.Feb 21 2017, 8:06 AM
In T158610#3041920, @matmarex wrote:

I think OS X doesn't normally display scrollbars at all, unless you have a mouse connected.

As of OS X 10.12.1 (Sierra) the scrollbar isn't visible all the time even when the mouse is connected. The behavior with the touchpad and mouse connected is the same now, that is, the scrolling rectangle shows up when you scroll the page, and a scrollbar shows up if the mouse pointer is at the edge of the screen.

Scrolling rectangle when you scroll the pageScrollbar when the mouse pointer is at the edge
Screen Shot 2017-02-21 at 1.34.25 PM.png (367×557 px, 66 KB)
Screen Shot 2017-02-21 at 1.34.45 PM.png (369×582 px, 60 KB)
• Prtksxna added a comment.Feb 21 2017, 8:07 AM
In T158610#3041985, @Volker_E wrote:

The issue is the inconsistency between browsers and dialogs in Safari though. As far as I understood, Chrome should behave similar in visibility.

Not able to spot any difference in behavior between Chrome 56 and Safari 10. Could you add instructions or a video to explain?

Volker_E added a comment.Mar 21 2017, 6:40 PM

No, there is a clear difference between latest Chrome and Safari for me. It seems to be connected to .oo-ui-panelLayout-scrollable rules.

• Prtksxna added a comment.Mar 22 2017, 5:39 AM
In T158610#3118734, @Volker_E wrote:

No, there is a clear difference between latest Chrome and Safari for me.

Could you add instructions or a video to explain?

Volker_E added a comment.Mar 22 2017, 5:54 AM

@Prtksxna Continuous outlined booklet dialog is showing scrollbar on my Chrome/Firefox per default.
Process dialog (medium, long) shows scrollbar in Chrome/Firefox/Safari per default.
If you disable the transform property, it becomes immediately visible in Safari as well. With it enabled, it's never visible.

• Prtksxna added a comment.Mar 27 2017, 8:53 AM
In T158610#3120790, @Volker_E wrote:

@Prtksxna Continuous outlined booklet dialog is showing scrollbar on my Chrome/Firefox per default.
Process dialog (medium, long) shows scrollbar in Chrome/Firefox/Safari per default.
If you disable the transform property, it becomes immediately visible in Safari as well. With it enabled, it's never visible.

In all these examples I don't see the scrollbar on default, and see it when I start scrolling. The behavior is consistent with my previous comment. What version of Mac OS are you on?

Volker_E added a comment.Mar 27 2017, 5:42 PM

10.11.6 and “Show scroll bars” preference is set to “Automatically based on mouse or trackpad”.

Volker_E merged a task: T181030: Vertical scrollbar does not appear inside dialogs in Safari when system is set to always show scrollbars.Dec 19 2017, 7:00 AM
Volker_E added subscribers: • Elitre, • Deskana, Esanders.
In T181030#3838243, @Esanders wrote:

This is a Safari bug which is an issue with OOUI dialogs. If you turn off transform:translateZ(0) (the GPU hack) the scrollbars return. I'm not sure if there is a way around this, but pinging @Volker_E as he's played with the GPU hack recently.

In T181030#3847204, @Volker_E wrote:

@Esanders This together with my comment on T154385#3847196 our original way out might need to be critically revisited. Need to look if [[ https://stackoverflow.com/questions/39261456/reducing-scroll-jank-when-using-overflow-y-scroll/39377543#39377543 | will-change is an alternative solution ]] for both, Chrome and Safari.

Volker_E renamed this task from BookletLayout/booklet dialog: Safari 10/OSX doesn't show vertical scrollbar to BookletLayout/booklet dialog: Safari 10/OSX doesn't show vertical scrollbar when system is set to always show scrollbars.Dec 19 2017, 7:01 AM
Volker_E removed a subscriber: Browser-Support-Apple-Safari.
• Elitre added a comment.Dec 19 2017, 10:15 AM
This comment was removed by • Elitre.
Volker_E mentioned this in T185051: PanelLayout-scrollable has rendering glitches in Chrome on various instances.Jan 16 2018, 11:31 PM
gerritbot subscribed.Jan 17 2018, 12:15 AM

Change 404608 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] PanelLayout: Remove buggy translateZ performance hack

https://gerrit.wikimedia.org/r/404608

gerritbot added a project: Patch-For-Review.Jan 17 2018, 12:15 AM
Volker_E moved this task from Backlog to OOUI-0.25.1 on the OOUI board.Jan 17 2018, 12:43 AM
Volker_E edited projects, added OOUI (OOUI-0.25.1); removed OOUI.
gerritbot added a comment.Jan 17 2018, 12:45 AM

Change 404608 merged by jenkins-bot:
[oojs/ui@master] PanelLayout: Remove buggy translateZ performance hack

https://gerrit.wikimedia.org/r/404608

Volker_E closed this task as Resolved.Jan 17 2018, 1:13 AM
Volker_E claimed this task.
Volker_E triaged this task as Low priority.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL