Page MenuHomePhabricator
Create Task
Maniphest T158657

Kartotherian error: GroupId not available
Closed, InvalidPublic
Actions

Assigned To
None
Authored By
Gehel
Feb 21 2017, 3:22 PM
Tags
Referenced Files
F10430772: no_js_safari_result.png
Oct 25 2017, 3:58 PM
F10430769: no_js_safari.png
Oct 25 2017, 3:58 PM
F10430674: Screen Shot 2017-10-25 at 16.25.23.png
Oct 25 2017, 3:29 PM
F10430676: Screen Shot 2017-10-25 at 16.27.55.png
Oct 25 2017, 3:29 PM
F5748693: Screen Shot 2017-02-21 at 3.40.26 PM.png
Feb 21 2017, 11:45 PM
Subscribers
Aklapper
debt
Gehel
jbond
Jc86035
• JGirault
MaxSem
View All 13 Subscribers
Tokens
"Like" token, awarded by Kozuch.

Description

The error below is seen frequently on maps1* servers. Some more investigation required to understand if there is an issue (and what the issue is) and either fix the issue or reduce the log level / verbosity.

[2017-02-21T15:14:53.500Z] ERROR: kartotherian/24 on maps1001: GroupId not available (err.levelPath=error)
    kartotherian: GroupId not available
        at /srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/kartotherian-snapshot/lib/mapdataLoader.js:53:19
        at tryCatcher (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/util.js:16:23)
        at Promise._settlePromiseFromHandler (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise.js:510:31)
        at Promise._settlePromise (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise.js:567:18)
        at Promise._settlePromise0 (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise.js:612:10)
        at Promise._settlePromises (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise.js:691:18)
        at Promise._fulfill (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise.js:636:18)
        at Promise._resolveCallback (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise.js:431:57)
        at Promise._settlePromiseFromHandler (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise.js:522:17)
        at Promise._settlePromise (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise.js:567:18)
        at Promise._settlePromise0 (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise.js:612:10)
        at Promise._settlePromises (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise.js:691:18)
        at Promise._fulfill (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise.js:636:18)
        at PromiseArray._resolve (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise_array.js:125:19)
        at PromiseArray._promiseFulfilled (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise_array.js:143:14)
        at Promise._settlePromise (/srv/deployment/kartotherian/deploy-cache/revs/abc731d9ad76337720e0741016001d590beb9492/node_modules/bluebird/js/release/promise.js:572:26)

Details

SubjectRepoBranchLines +/-
Log a warning rather than throwing an error when groupdata not foundmediawiki/services/kartotherianmaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Gehel created this task.Feb 21 2017, 3:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2017, 3:22 PM
• JGirault added a subscriber: • JGirault.EditedFeb 21 2017, 8:51 PM

This snapshot image works:
?domain=www.mediawiki.org&title=Help%3AExtension%3AKartographer&groups=_063499af64a79f361aab32753fbe1ca8f5d3782d

However, we get this GroupId not available error with:

  1. ?domain=www.mediawiki.org&title=Help%3AExtension%3AKartographer&groups=invalid_hash
  2. ?domain=www.mediawiki.org&title=Help%3AExtension%3AKartographer&groups=
  3. ?domain=www.mediawiki.org&title=Help%3AExtension%3AKartographer
  4. ?domain=www.mediawiki.org&title=invalid_title

The error is thrown at https://github.com/kartotherian/kartotherian-snapshot/blob/master/lib/mapdataLoader.js#L53

In most cases they aren't caused by errors in the system, rather by invalid parameters and that can be handled better.

• JGirault added a subscriber: Yurik.Feb 21 2017, 9:13 PM

I started a simple PR to https://github.com/kartotherian/kartotherian-snapshot/pull/4 (@Yurik ping), but it's not really answering the current problem.

• JGirault added a comment.Feb 21 2017, 11:45 PM

I think the problem is mostly seen right after saving an edit, when the database isn't ready. It takes a couple of minutes before it is.
The snapshot service asks for the group ID and fails.

The user sees :

Screen Shot 2017-02-21 at 3.40.26 PM.png (480×494 px, 24 KB)

Yurik added a comment.Feb 21 2017, 11:48 PM

This is easy enough to fix by adding data to memcached when saving, just like we do in graphoid. Moreover, this can be done at the jsonconfig level.

debt removed a project: Maps-Sprint.Jun 14 2017, 9:16 PM
debt added a subscriber: debt.

Moving off the sprint board - the Discovery team won't be able to do this work at this time.

Gehel mentioned this in T163239: Bad geojson - unknown type ExternalData.Jun 15 2017, 7:47 AM
debt triaged this task as High priority.Jun 15 2017, 3:25 PM
This comment was removed by debt.
debt lowered the priority of this task from High to Low.Jun 15 2017, 3:55 PM
Krinkle added a subscriber: Krinkle.Oct 24 2017, 7:05 PM

I can reproduce this consistently on the following page:

https://en.wikivoyage.org/wiki/South_Central_Arizona

GET https://maps.wikimedia.org/img/osm-intl,9,31.79,-111.04,420x420.png?domain=en.wikivoyage.org&title=South+Central+Arizona&groups=mask%2Caround%2Cbuy%2Ccity%2Cdo%2Cdrink%2Ceat%2Cgo%2Clisting%2Cother%2Csee%2Csleep%2Cvicinity%2Cview%2Cblack%2Cblue%2Cbrown%2Cchocolate%2Cforestgreen%2Cgold%2Cgray%2Cgrey%2Clime%2Cmagenta%2Cmaroon%2Cmediumaquamarine%2Cnavy%2Cred%2Croyalblue%2Csilver%2Csteelblue%2Cteal%2Cfuchsia
HTTP 400 Bad Request
"GroupId not available"

Krinkle edited projects, added Maps; removed Maps (Kartotherian).Oct 24 2017, 7:06 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptOct 24 2017, 7:06 PM
Krinkle moved this task from All map-related tasks to Kartographer on the Maps board.Oct 24 2017, 7:06 PM
Krinkle edited projects, added Maps (Kartographer); removed Maps.
Krinkle moved this task from Kartographer to Kartotherian on the Maps board.
Krinkle edited projects, added Maps (Kartotherian); removed Maps (Kartographer).

Sorry, didn't realise Maps was the same project as Maps (Kartotherian). Adding Maps made it remove itself from Maps (Kartotherian). Restored now :)

debt added a comment.Oct 25 2017, 3:06 PM
In T158657#3707822, @Krinkle wrote:

I can reproduce this consistently on the following page:

https://en.wikivoyage.org/wiki/South_Central_Arizona

GET https://maps.wikimedia.org/img/osm-intl,9,31.79,-111.04,420x420.png?domain=en.wikivoyage.org&title=South+Central+Arizona&groups=mask%2Caround%2Cbuy%2Ccity%2Cdo%2Cdrink%2Ceat%2Cgo%2Clisting%2Cother%2Csee%2Csleep%2Cvicinity%2Cview%2Cblack%2Cblue%2Cbrown%2Cchocolate%2Cforestgreen%2Cgold%2Cgray%2Cgrey%2Clime%2Cmagenta%2Cmaroon%2Cmediumaquamarine%2Cnavy%2Cred%2Croyalblue%2Csilver%2Csteelblue%2Cteal%2Cfuchsia
HTTP 400 Bad Request
"GroupId not available"

@Krinkle - can you list steps to reproduce this issue and creation of the URL? When going to the page and clicking on the individual maplinks (or on the interactive map), I can't get the error to occur.

Krinkle added a comment.Oct 25 2017, 3:29 PM
In T158657#3709989, @debt wrote:
In T158657#3707822, @Krinkle wrote:

I can reproduce this consistently on the following page:

https://en.wikivoyage.org/wiki/South_Central_Arizona
[..]

@Krinkle - can you list steps to reproduce this issue and creation of the URL? When going to the page and clicking on the individual maplinks (or on the interactive map), I can't get the error to occur.

The error happens directly on page load. No additional user steps.

  1. Navigate to https://en.wikivoyage.org/wiki/South_Central_Arizona
  2. Open browser developer tools to observe the failed request, in either the Network tab or the Console.
Screen Shot 2017-10-25 at 16.25.23.png (1×2 px, 1 MB)
Screen Shot 2017-10-25 at 16.27.55.png (356×2 px, 117 KB)
debt added a comment.Oct 25 2017, 3:31 PM
In T158657#3710184, @Krinkle wrote:
In T158657#3709989, @debt wrote:
In T158657#3707822, @Krinkle wrote:

I can reproduce this consistently on the following page:

https://en.wikivoyage.org/wiki/South_Central_Arizona
[..]

@Krinkle - can you list steps to reproduce this issue and creation of the URL? When going to the page and clicking on the individual maplinks (or on the interactive map), I can't get the error to occur.

The error happens directly on page load. No additional user steps.

  1. Navigate to https://en.wikivoyage.org/wiki/South_Central_Arizona
  2. Open browser developer tools to observe the failed request, in either the Network tab or the Console.
Screen Shot 2017-10-25 at 16.25.23.png (1×2 px, 1 MB)
Screen Shot 2017-10-25 at 16.27.55.png (356×2 px, 117 KB)

Ah, I see now. Normal users of the pages don't see the errors, but the errors *do* exist in developer tools. Thanks for the clarification! :)

Gehel added a comment.Oct 25 2017, 3:37 PM

We first load a static picture of the map (which is broken), which is then replaced by an interactive map. So if it loads fast enough, you don't actually see the failed static image.

My understanding was that the switch to interactive map should only happen on user interaction (but either I am wrong, or there is a bug).

This still means that this map is broken for users without JS enabled.

As to how to fix that... maybe @MaxSem can help, but this requires digging into kartotherian...

debt added a comment.Oct 25 2017, 3:58 PM
In T158657#3710212, @Gehel wrote:

We first load a static picture of the map (which is broken), which is then replaced by an interactive map. So if it loads fast enough, you don't actually see the failed static image.

My understanding was that the switch to interactive map should only happen on user interaction (but either I am wrong, or there is a bug).

This still means that this map is broken for users without JS enabled.

As to how to fix that... maybe @MaxSem can help, but this requires digging into kartotherian...

I don't think the static map service is enabled on Wikivoyage (by default)....and, apparently my connection is fast enough (whoa!) that I don't see the failed image. However, when turning off JS in my safari browser, I just see a blank box where the map should be, no error:

no_js_safari.png (682×781 px, 230 KB)

and clicking on the map only shows this (not a good user experience):

no_js_safari_result.png (398×349 px, 62 KB)

• Mholloway added a subscriber: • Mholloway.May 11 2018, 9:03 PM
Krinkle removed a subscriber: Krinkle.May 12 2018, 12:41 AM
• Jhernandez removed a project: Discovery-ARCHIVED.Jul 10 2018, 4:36 PM
Pnorman raised the priority of this task from Low to Medium.Jul 10 2018, 4:40 PM
Pnorman added a subscriber: Pnorman.

This is still the most common message in the logs.

• Jhernandez added a project: Maps-Sprint.Jul 10 2018, 4:41 PM
LGoto added a project: Product-Infrastructure-Team-Backlog-Deprecated.Jul 25 2018, 3:59 PM
• Jhernandez moved this task from Needs triage to Backlog on the Product-Infrastructure-Team-Backlog-Deprecated board.Aug 1 2018, 3:36 PM
• Mholloway mentioned this in T159013: Snapshot not working for Data pages.Aug 28 2018, 3:09 PM
MSantos removed a project: Maps-Sprint.Sep 26 2018, 3:01 PM
Jc86035 added a subscriber: Jc86035.EditedDec 13 2018, 2:53 PM

This still happens whenever mapframe is used in Special:ExpandTemplates (example). It's probably happening on a lot of pages right now because I just enabled it in {{Infobox bridge}}. (It's also worse on enwiki because the interactive map isn't displayed except for in the full window view.)

TheDJ mentioned this in T214984: PHP7's stricter JSON parsing breaks some wiki content.Feb 8 2019, 7:05 AM
Strainu raised the priority of this task from Medium to High.May 22 2019, 9:47 AM
Strainu added subscribers: • Jhernandez, Strainu.

This is also happening on ro.wiki since I enabled it in InfoboxSettlement. As more and more pages use mapframe, we will need a solution, so trying to raise priority.

Is there a workaround we can put in place? See: https://ro.wikipedia.org/wiki/Provincia_Entre_R%C3%ADos

Pikne added a subscriber: Pikne.May 22 2019, 12:32 PM
In T158657#5203621, @Strainu wrote:

Is there a workaround we can put in place? See: https://ro.wikipedia.org/wiki/Provincia_Entre_R%C3%ADos

All I can think of is to null edit all affected pages that display map via this template.

This error to my vague understanding can be observed whenever map content is changed, but GeoJSON in page_props table isn't updated yet for page where map is displayed (e.g. when map content is changed via template or when static map with new content is requested in page preview).

Kozuch awarded a token.Aug 5 2019, 12:14 PM
Kozuch mentioned this in T229800: Map thumbnail does not show sometimes.
• Jhernandez moved this task from Backlog to Tracking on the Product-Infrastructure-Team-Backlog-Deprecated board.Aug 8 2019, 12:39 PM
• Jhernandez added a project: patch-welcome.
jbond added a subscriber: jbond.Sep 13 2019, 9:18 AM
gerritbot added a comment.Sep 13 2019, 4:02 PM

Change 536628 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/services/kartotherian@master] Log a warning rather than throwing an error when groupdata not found

https://gerrit.wikimedia.org/r/536628

gerritbot added a project: Patch-For-Review.Sep 13 2019, 4:02 PM
gerritbot added a comment.Sep 13 2019, 4:46 PM

Change 536628 merged by jenkins-bot:
[mediawiki/services/kartotherian@master] Log a warning rather than throwing an error when groupdata not found

https://gerrit.wikimedia.org/r/536628

MSantos merged a task: T159013: Snapshot not working for Data pages.Apr 1 2020, 1:23 PM
• Jhernandez removed a subscriber: • Jhernandez.Apr 2 2020, 6:46 PM
MSantos mentioned this in T269984: Defective static thumbnail, generated in page preview using an empty GeoJSON layer, is cached for long time after saving.Dec 14 2020, 11:18 AM
WMDE-Fisch closed this task as Invalid.Mar 22 2023, 12:34 PM
WMDE-Fisch removed a project: Patch-For-Review.
WMDE-Fisch added a subscriber: WMDE-Fisch.

The error was altered and downgraded to a warning, If I'm not mistaken its not appearing anymore. I guess it makes sense to create a new ticket when there's a new lead.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL