Page MenuHomePhabricator

Keyholder accept passwordless keys
Closed, ResolvedPublic

Description

There is a bug in keyholder's code that don't exclude as expected the passwordless keys

Details

Event Timeline

Volans renamed this task from Keyholder: to Keyholder accept passwordless keys.Feb 21 2017, 3:37 PM
Volans claimed this task.
Volans triaged this task as High priority.
Volans added a project: SRE.
Volans updated the task description. (Show Details)
Volans moved this task from Backlog to In Progress on the SRE-tools board.
Volans moved this task from In Progress to In Code Review on the SRE-tools board.

Change 338984 had a related patch set uploaded (by Volans):
Keyholder: fix filter of passwordless keys

https://gerrit.wikimedia.org/r/338984

@mmodell I'm not sure what's the status with the https://phabricator.wikimedia.org/source/keyholder/ repository that was recently created.

I've sent the patch against puppet repo as usual for now. See also the other related patch in T158659

@Volans: Thanks for the heads-up. We still use the code from puppet in prod. It will will remain that way until I get the package accepted by ops and change puppet to use the keyholder package from apt.

Change 338984 merged by Volans:
Keyholder: fix filter of passwordless keys

https://gerrit.wikimedia.org/r/338984

Mentioned in SAL (#wikimedia-operations) [2017-02-24T14:27:37Z] <volans> re-started and re-armed keyholder after upgrade on: mira.codfw.wmnet,neodymium.eqiad.wmnet,sarin.codfw.wmnet,tin.eqiad.wmnet T158660 T158659

Volans moved this task from In Code Review to Done on the SRE-tools board.