Page MenuHomePhabricator
Create Task
Maniphest T158665

"Edit" pencil is not shown for all sections/sub-sections of an article
Closed, ResolvedPublic
Actions

Description

The app doesn't seem to be showing the edit pencil for every section/sub-section of an article. To be exact, it seems to be showing the edit pencil only for sections of alternative levels of depth.

This makes it hard for a user to edit big articles as he is not able to edit every section/sub-section of an article.

Steps to reproduce

  1. Go to "Scrum (software development)"
  2. Scroll down to the "Roles" -> "Product Owner" subsection.

Expected results
User is able to edit every section/sub-section of an article (i.e.) the edit pencil is shown for every section/sub-section of an article.

Actual results
The edit pencil is shown only for section-level headings, and not for subsections.

Screen shot

Screenshot_2017-02-21-22-04-24.png (800×480 px, 136 KB)

Environments observed
Device Vendor : Samsung
Model : GT-S7582
Android : Cyanogenmod 11 (4.4.4-Kitkat)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update CSS assets (updates edit pencil styles)apps/android/wikipediamaster+0 -16
Show edit pencil for all sections.mediawiki/extensions/MobileAppmaster+0 -10
Customize query in gerrit

Event Timeline

Kaartic created this task.Feb 21 2017, 4:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2017, 4:36 PM
Venkatvb subscribed.Feb 21 2017, 7:26 PM
gerritbot subscribed.Mar 3 2017, 2:34 PM

Change 338992 had a related patch set uploaded (by dbrant):
[mediawiki/extensions/MobileApp] Show edit pencil for all sections.

https://gerrit.wikimedia.org/r/338992

gerritbot added a project: Patch-For-Review.Mar 3 2017, 2:34 PM
gerritbot added a comment.Mar 6 2017, 8:19 PM

Change 338992 merged by jenkins-bot:
[mediawiki/extensions/MobileApp] Show edit pencil for all sections.

https://gerrit.wikimedia.org/r/338992

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)).Mar 6 2017, 9:00 PM
gerritbot added a comment.Mar 10 2017, 12:57 AM

Change 342159 had a related patch set uploaded (by Mholloway):
[apps/android/wikipedia] Update CSS assets (updates edit pencil styles)

https://gerrit.wikimedia.org/r/342159

gerritbot added a comment.Mar 10 2017, 1:52 PM

Change 342159 merged by jenkins-bot:
[apps/android/wikipedia] Update CSS assets (updates edit pencil styles)

https://gerrit.wikimedia.org/r/342159

Dbrant claimed this task.Mar 16 2017, 12:47 PM
Dbrant added a project: Android-app-release-v2.5.19x-Ananas🍍.
Dbrant updated the task description. (Show Details)
Dbrant moved this task from To Do to QA Signoff on the Android-app-release-v2.5.19x-Ananas🍍 board.
Nicholas.tsg subscribed.Mar 21 2017, 9:54 PM

Testing on Samsung Galaxy Express 3 (J120A) with Android 6.0.1 and Wikipedia Alpha app 2.5.190-alpha-2017-03-21.
This is fixed as according to the below screencap the edit pencil is shown in subsections again (such as "Extensions" in the "Scrum (software development)" article)

T158665.png (800×480 px, 90 KB)

• NHarateh_WMF removed a project: Wikipedia-Android-App-Backlog.Mar 22 2017, 4:25 PM
ABorbaWMF moved this task from QA Signoff to Ready for Signoff on the Android-app-release-v2.5.19x-Ananas🍍 board.Mar 23 2017, 8:40 PM
ABorbaWMF subscribed.

Tested on a Pixel with Android 7.1.1 and the Alpha App 2.5.190-alpha-2017-03-23

Appears to be fixed

Dbrant moved this task from Ready for Signoff to Done on the Android-app-release-v2.5.19x-Ananas🍍 board.Mar 29 2017, 4:05 PM
Dbrant closed this task as Resolved.Mar 29 2017, 4:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits