| Esanders | |
| Feb 22 2017, 2:27 PM |
| F5764623: pasted_file | |
| Feb 22 2017, 2:27 PM |
| F5764603: pasted_file | |
| Feb 22 2017, 2:27 PM |
Having cleaned up the DiffElement code to use raw DOM operations instead of jQuery, we can see that the actual DOM being returned is less correct that we thought:
The removed cells are actually nested inside the cells to their left, but jQuery was fixing this:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T143341 When re-starting a local draft, show the user a diff so they know what they're getting into | |||
| Open | None | T105173 HTML diffs of edits for everything | |||
| Resolved | Tchanders | T143350 Let users choose a visual or wikitext diff in the review-your-changes tab | |||
| Resolved | Esanders | T158769 Visual diffing: Deleting a table row doesn't append the removed cells in the right place |
Change 339184 had a related patch set uploaded (by Esanders):
Use node.get*Outer*Range() when splicing in removes
Change 339184 merged by jenkins-bot:
Use node.get*Outer*Range() when splicing in removes
Change 339481 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (813c586a6)