Page MenuHomePhabricator

Reuse code for parsing site link badge data in SetSiteLink API class
Closed, ResolvedPublic


While refactoring ChangeOp instantiating logic out of Api\EditEntity (T154288) the code responsible for parsing site link's badge data has been moved out from ModifyEntity::parseSiteLinkBadges to a dedicated class SiteLinkBadgeChangeOpSerializationValidator.
ModifyEntity::parseSiteLinkBadges still exists, as it is also used by Api\SetSiteLink. SetSiteLink should be using the dedicated class, and the method in question should be removed from ModifyEntity for good.

Event Timeline

Change 340527 had a related patch set uploaded (by Jakob):
[mediawiki/extensions/Wikibase] Reuse badge serialization validation in SetSiteLink.

Change 340527 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Reuse badge serialization validation in SetSiteLink.