Page MenuHomePhabricator

[minor] RC filters with 'Enhanced recent changes': Summarizing edits with 0 net result won't be highlighted
Closed, ResolvedPublic

Description

  1. Enable 'Enhanced recent changes' in Preferences-Recent changes.
  2. On Recent changes page if the summary entries display 0 net changes (in characters), it won't be highlighted, even though all entries in the summary are highlighted.

Screen Shot 2017-02-24 at 12.39.09 PM.png (377×1 px, 166 KB)

Uncollapsed view shows that all entries are highlighted.
Screen Shot 2017-02-24 at 12.31.27 PM.png (345×1 px, 148 KB)

Event Timeline

The highlighting of the group was not caused by the 0-byte net change but by whether a page is watched or not. It was changed (and merged) in https://gerrit.wikimedia.org/r/#/c/340349/ to never highlight the group.

Please confirm that this change works and that groups are never highlighted regardless of bytes added/removed.

The decision to NOT highlight group was the simplest one to implement for consistency in the short-term but it's not ideal. Because groups are collapsed by default, they may hide interesting (highlighted) lines.

@SBisson It seems that something else is involved there - I got a quite different outcomes when I use the same filter and the same highlighting with 'Enhanced recent changes' vs not using the option.
(1) 'Enhanced recent changes'., 'Human (not bot)', green highlighting
Notice:

  • 'User rights log' and 'User creation' log are not highlighted
  • the page 'User:RYasmeen (WMF)/sandbox' is not highlighted. The page is added to my watchlist.
  • when expanded, all entries will be highlighted

Screen Shot 2017-03-07 at 6.21.41 PM.png (684×784 px, 215 KB)

Screen Shot 2017-03-07 at 6.49.37 PM.png (740×910 px, 273 KB)

(2) Without option 'Enhanced recent changes'

Screen Shot 2017-03-07 at 6.24.17 PM.png (693×807 px, 232 KB)

@Etonkovidova the lines you have circled in red are group headers. They are never highlighted. When you expand them, you see the inner changes, which are highlighted.

the lines you have circled in red are group headers. They are never highlighted. When you expand them, you see the inner changes, which are highlighted.

@SBisson - thanks! Sorry, It seems that I did not pay attention to your previous comment:

The decision to NOT highlight group was the simplest one to implement for consistency in the short-term but it's not ideal. Because groups are collapsed by default, they may hide interesting (highlighted) lines.

The following is verified:

Please confirm that this change works and that groups are never highlighted regardless of bytes added/removed.

Screen Shot 2017-03-08 at 9.41.39 AM.png (205×833 px, 99 KB)

QA recommendation: Product should weigh in.

jmatazzoni claimed this task.
jmatazzoni subscribed.

As long as all non-group lines are being highlighted, and the group lines are highlighted once expanded, then this functionality is adequate for now.

I've created a ticket for ext quarter exploring ways to make this work bette r-- T159896. (And I've added this issue to the Highlighting Help page.)

Resolving this.