Maniphest T159012

Language search is not visible when beta is enabled
Closed, ResolvedPublic2 Story Points
Actions

Description

Steps to Reproduce:

Navigate to a page (example - en.m.wikipedia.org)
Login using an existing account
Navigate to Settings and turn Beta features on
View any article with multiple languages
Tap the languages icon

Expected Result:
A list of available languages appears with a search entry field at the top for searching languages.

Actual Result:
No search appears

Systems details:
Galaxy S5 Android 4.4 - Chrome 35
Pixel Android 7.1 - Chrome 52
iPhone 6S iOS 9 - Safari 9.0

Related Objects

Mentioned Here: T157987: Prepare branding branch for merging to master

Event Timeline

ABorbaWMF created this task.Feb 24 2017, 11:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2017, 11:49 PM

Introduced in (https://gerrit.wikimedia.org/r/#/c/336352/3/resources/skins.minerva.base.styles/ui.less) - T157987

Styles that cause search bar to disappear: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/skins.minerva.base.styles/ui.less#L175

pmiazga added a project: Unplanned-Sprint-Work.Feb 25 2017, 12:18 AM

Change 339801 had a related patch set uploaded (by Pmiazga):
Hide header_v2 .search-box oly when it's inside header

https://gerrit.wikimedia.org/r/339801

gerritbot added a project: Patch-For-Review.Feb 25 2017, 12:20 AM

I'm not sure if my patch fixes the problem as I cannot test it locally yet - please test it first (you need multilang support)

ovasileva triaged this task as High priority.Feb 26 2017, 11:52 AM

ovasileva moved this task from Incoming to 2016-17 Q3 on the Readers-Web-Backlog board.

ovasileva moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-92-🍜 board.Feb 27 2017, 5:30 PM

@phuedx to create a follow up tech debt task. This one needs a quick and dirty fix for now.

pmiazga claimed this task.Feb 27 2017, 8:39 PM

oops, wrong task

bmansurov moved this task from Ready for Signoff to Needs Code Review on the Reading-Web-Sprint-92-🍜 board.Feb 27 2017, 9:49 PM

pmiazga moved this task from Needs Code Review to Needs More Work on the Reading-Web-Sprint-92-🍜 board.Feb 27 2017, 11:28 PM

pmiazga moved this task from Needs More Work to Needs Code Review on the Reading-Web-Sprint-92-🍜 board.Feb 28 2017, 3:58 PM

Quick fix applied

Change 339801 merged by jenkins-bot:
Always show the .search-box inside language overlay

https://gerrit.wikimedia.org/r/339801

The fix can be tested at https://en.m.wikipedia.beta.wmflabs.org/wiki/Barack_Obama?mobileaction=beta#/languages

bmansurov reassigned this task from pmiazga to ovasileva.Feb 28 2017, 8:08 PM

bmansurov removed a project: Patch-For-Review.

This appears to be fixed on Wikipedia beta.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)).Feb 28 2017, 9:00 PM

ovasileva added a comment.Mar 1 2017, 9:56 AM

This comment was removed by ovasileva.

ovasileva added a comment.Mar 1 2017, 9:57 AM

This comment was removed by ovasileva.

Ah, nm, confirmed on beta cluster