Page MenuHomePhabricator
Create Task
Maniphest T159015

CollaborationHubContent: Don't show join button on members block for non-logged-in users if they do not have edit or account creation rights
Closed, ResolvedPublic
Actions

Description

Check if the users can even create an account at all, or edit without creating an account, before we try to nudge them into doing so.

Hide the join button if not.

Details

SubjectRepoBranchLines +/-
Do permissions checks for hub edit buttons and such after main parse to avoid caching problemsmediawiki/extensions/CollaborationKitmaster+279 -136
Use newfangled permissionmanager stuff and more consistently check for appropriate permissions on collaborationhubsmediawiki/extensions/CollaborationKitmaster+102 -51
Customize query in gerrit

Related Objects

Event Timeline

Isarra created this task.Feb 25 2017, 12:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2017, 12:19 AM
Harej triaged this task as Medium priority.Feb 25 2017, 12:43 AM
Harej moved this task from Backlog to Release blockers on the MediaWiki-extensions-CollaborationKit board.
Harej subscribed.Feb 25 2017, 12:47 AM

Tangentially related, the buttons just straight up don't work if the user is logged out. Should the buttons be hidden under this circumstance as well?

Harej added a comment.Feb 25 2017, 12:51 AM

(That's the main reason why I sorted this under first release.)

Harej added a comment.Feb 25 2017, 8:00 AM

I will submit a patch to hide the join button for non-logged in users, and defer this particular thing for another time.

Harej moved this task from Release blockers to Future Releases on the MediaWiki-extensions-CollaborationKit board.Feb 25 2017, 8:00 AM
Isarra moved this task from Future Releases to Release blockers on the MediaWiki-extensions-CollaborationKit board.Jan 17 2019, 9:27 PM
Isarra moved this task from Release blockers to Release bugs on the MediaWiki-extensions-CollaborationKit board.Jan 17 2019, 10:41 PM
Isarra moved this task from Release bugs to In Progress on the MediaWiki-extensions-CollaborationKit board.Apr 9 2019, 7:01 PM
Isarra mentioned this in rECKT65f5eb191d57: Use newfangled permissionmanager stuff and more consistently check for….Apr 13 2019, 3:30 AM
ashley mentioned this in rECKT982eab73a314: Use newfangled permissionmanager stuff and more consistently check for….Apr 18 2019, 9:10 PM
gerritbot added a comment.Apr 18 2019, 9:12 PM

Change 503548 had a related patch set uploaded (by Isarra; owner: Jack Phoenix):
[mediawiki/extensions/CollaborationKit@master] Use newfangled permissionmanager stuff and more consistently check for appropriate permissions on collaborationhubs

https://gerrit.wikimedia.org/r/503548

gerritbot added a project: Patch-For-Review.Apr 18 2019, 9:12 PM
ashley mentioned this in rECKT22ee22ac4f9b: Use newfangled permissionmanager stuff and more consistently check for….Apr 18 2019, 9:15 PM
Isarra mentioned this in rECKT8aeb81da2032: Use newfangled permissionmanager stuff and more consistently check for….Apr 18 2019, 9:15 PM
Isarra mentioned this in rECKT06e82ba9c48e: Use newfangled permissionmanager stuff and more consistently check for….Apr 19 2019, 8:54 PM
gerritbot added a comment.Apr 27 2019, 11:04 PM

Change 506887 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/extensions/CollaborationKit@master] Do permissions checks for hub edit buttons and such after main parse

https://gerrit.wikimedia.org/r/506887

Isarra mentioned this in rECKT881f42752690: Do permissions checks for hub edit buttons and such after main parse.Apr 27 2019, 11:09 PM
Isarra mentioned this in rECKTe0473af06819: Do permissions checks for hub edit buttons and such after main parse.Apr 28 2019, 3:43 PM
Isarra mentioned this in rECKT2f44f9b1a435: Do permissions checks for hub edit buttons and such after main parse to avoid….Apr 28 2019, 3:50 PM
Isarra mentioned this in rECKT0e9fe44a8f82: Do permissions checks for hub edit buttons and such after main parse.
Isarra mentioned this in rECKT172dcd67e356: Do permissions checks for hub edit buttons and such after main parse to avoid….Apr 28 2019, 4:14 PM
Isarra mentioned this in rECKT832807bf0462: Do permissions checks for hub edit buttons and such after main parse to avoid….Apr 29 2019, 7:42 PM
Isarra mentioned this in rECKT029b400e11ed: Do permissions checks for hub edit buttons and such after main parse to avoid….
Isarra mentioned this in rECKT6541f20121cb: Do permissions checks for hub edit buttons and such after main parse to avoid….Apr 30 2019, 12:00 AM
gerritbot added a comment.Apr 30 2019, 12:02 AM

Change 503548 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Use newfangled permissionmanager stuff and more consistently check for appropriate permissions on collaborationhubs

https://gerrit.wikimedia.org/r/503548

gerritbot added a comment.Apr 30 2019, 12:14 AM

Change 506887 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Do permissions checks for hub edit buttons and such after main parse to avoid caching problems

https://gerrit.wikimedia.org/r/506887

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 30 2019, 1:00 AM
Isarra closed this task as Resolved.Apr 30 2019, 6:23 PM
Isarra claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL