Page MenuHomePhabricator
Create Task
Maniphest T159043

Replace deprecated phabricator conduit api calls in phab_epipe.py file
Closed, DeclinedPublic
Actions

Description

We should migrate this file to use maniphest.edit conduit api as maniphest.update is deprecated and can be removed at any time.

https://github.com/wikimedia/puppet/blob/a6872e4ae8411126b1de648cf8f78c02a72e2313/modules/phabricator/files/phab_epipe.py#L146

Details

SubjectRepoBranchLines +/-
Use maniphest.edit in phab_epipe.pyoperations/puppetproduction+10 -2
Customize query in gerrit

Related Objects

Event Timeline

Paladox created this task.Feb 25 2017, 2:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2017, 2:14 PM
Aklapper added a project: Technical-Debt.Feb 25 2017, 6:01 PM
Paladox renamed this task from Update file phab_epipe.py to use maniphest.edit conduit api to Replace deprecated phabricator conduit api calls in phab_epipe.py file.Feb 27 2017, 12:53 AM
Ottomata removed a project: SRE.Mar 6 2017, 7:47 PM
greg moved this task from INBOX to Backlog on the Release-Engineering-Team board.May 20 2017, 11:59 AM
greg edited projects, added Release-Engineering-Team (Backlog); removed Release-Engineering-Team.
gerritbot subscribed.Jun 6 2017, 9:43 AM

Change 357354 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/puppet@production] Use maniphest.edit in phab_epipe.py

https://gerrit.wikimedia.org/r/357354

gerritbot added a project: Patch-For-Review.Jun 6 2017, 9:43 AM
• mmodell triaged this task as Low priority.Jun 6 2017, 9:46 AM
Dzahn unsubscribed.Jun 6 2017, 11:00 PM
gerritbot added a comment.Nov 17 2017, 2:01 PM

Change 357354 abandoned by Rush:
Use maniphest.edit in phab_epipe.py

Reason:
code path no longer used

https://gerrit.wikimedia.org/r/357354

Aklapper closed this task as Declined.Jun 29 2018, 10:50 AM

As this is an unused code path nowadays I decline this task because the related patch was also declined. (Cannot fix this task without accepting a patch, eh).

Aklapper mentioned this in T159045: Update Puppet repo code that uses deprecated maniphest.update/.createtask/.query Conduit API.Jun 29 2018, 11:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL