Page MenuHomePhabricator

The Hebrew version of upload wizard
Closed, ResolvedPublic

Description

Upload wizard in Hebrew (and only in Hebrew) does not allowed accepting the license "PD-Israel" as a valid license. Screenshots for example:

English: https://commons.wikimedia.org/wiki/File:Screenshot.English.png - no problem
Russian: https://commons.wikimedia.org/wiki/File:Screenshot.Russian.png - no problem
Georgian: https://commons.wikimedia.org/wiki/File:Screenshot.Georgian.png - no problem
Hebrew: https://commons.wikimedia.org/wiki/File:Screenshot.Hebrew.png - Problem --> No valid license

Event Timeline

Geagea created this task.Feb 27 2017, 12:05 AM
Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 27 2017, 12:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Just a note. It was ok before but was changed from unknown reason.

IKhitron renamed this task from The Hebwer version of upload wizard to The Hebrew version of upload wizard .Feb 27 2017, 1:32 AM

Do you have a date? Or at least the last time it worked vs the first time it wasn't, Gea?

Geagea added a comment.EditedFeb 27 2017, 1:46 AM

I am not using the upload wizard for my self but saw users uploading files with PD-IsraelGov and wonderd why they are doing so. This was probabely the problem. At least month.

And at most?

Can you copy-paste the error text (the same as shown in the screenshot)? It would be useful to search for the text, to see where it comes from, and I can't type in Hebrew. :)

קוד הוויקי שהזנת אינו מכיל תבנית רישוי תקינה

Same massage you have in English in the license not valid.

IKhitron: I'm seeing uploads of User:Sokuya with PD-IsraelGov back to june 2016. May be it is better to ask him if this was the problem.

Geagea added a comment.EditedFeb 27 2017, 2:05 AM

קוד הוויקי שהזנת אינו מכיל תבנית רישוי תקינה = The wikitext you entered doesn't contain a valid license template.

Thanks, but the time between Juny and February is too long. If we had a month, we could check the template history and relevant mediawiki deployments.

Sorry, I have no idea since when the problem appears.

Possibly started since we started checking for licenses to use Template:Template_license_tag (T140903)

Oddly, this API request (which we use to check if said template is included) produces different results when my interface language is set to he:
https://commons.wikimedia.org/w/api.php?action=parse&format=json&prop=templates&title=File%3AUploadWizard+license+verification.png&text={{PD-Israel}}&errorformat=html&errorlang=he&errorsuselocal=1&formatversion=2

see English vs Hebrew

That template uses an {{autotranslate|base=PD-Israel}}, so it includes Template:PD-Israel/en or Template:PD-Israel/he depending on the language.

Template:PD-Israel/en includes Template:PD-Israel/layout, which includes Template:PD-Layout, which in turn includes Template:License template tag.
Template:PD-Israel/he includes Template:PD-Layout-RTL, which doesn't include Template:License template tag.

Simply adding {{License template tag}} in there (probably best in Template:PD-Layout-RTL?) should fix this!

matmarex edited subscribers, added: Steinsplitter; removed: Aklapper.Feb 27 2017, 4:44 PM
matmarex added a subscriber: Aklapper.

Thanks for investigating. Template:PD-Layout-RTL seems to be a unique thing, no other similar templates have separate RTL versions. And it seems that Template:PD-Layout supports RTL (it has some switches depending on text directionality).

So… I just redirected Template:PD-Layout-RTL to Template:PD-Layout: https://commons.wikimedia.org/w/index.php?title=Template:PD-Layout-RTL&diff=235469956&oldid=15255233. @IKhitron @Geagea Can you confirm that this fixes the issue for you?

I don't know what happens inside the uploader, @matmarex, Gea should answer on this, but I think there was a reason that this template was created in the first place, including the edit summary "didn't solve the problem". So there was some problem.

It was also in 2008, nine years ago. :) I'm not sure if problems from then still apply now. Looking at https://commons.wikimedia.org/w/index.php?title=Template:PD-Layout&action=history, a number of changes happened that were not reflected in the RTL version, including one that claims to fix an RTL bug. Other similar templates (e.g. Template:CC-Layout) never had an RTL version. If https://commons.wikimedia.org/wiki/Template:PD-Israel doesn't look broken (and it looks fine to me), I think redirecting was better.

Geagea added a comment.EditedFeb 28 2017, 6:25 AM

I think it's work now. seems that some issues improved. Thanks IKhitron, matmarex and matthiasmullie.

matmarex closed this task as Resolved.Feb 28 2017, 8:06 PM