Page MenuHomePhabricator
Create Task
Maniphest T159122

Consider translated optional messages towards meeting the export threshold
Closed, ResolvedPublic
Actions

Description

Request: add 1 to the total messages and translated messages when an optional message is translated.

At least since 2011 (perhaps always), optional messages are not considered in statistics for how much a group is translated. This is good to avoid "falsely" reporting a group as partially untranslated when all non-optional messages are translated; but it's bad when a group is reported as fully untranslated and below the export threshold.

Case at hand: https://gerrit.wikimedia.org/r/#/c/339601/3 / eb8b6d3099e79c47397d1258770d7cc03611f762 . https://translatewiki.net/wiki/Special:LanguageStats/ang shows "pywikibot redirect" 0 % translated, i.e. 0/5, when it's actually 1/6 translated, but the one translated message is optional. https://translatewiki.net/w/i.php?title=Special:Translate&group=out-pywikipedia-redirect&language=ang&filter=&action=translate&optional=1

I believe there might have been another report about outdated/fuzzied optional messages.

See also: T41068: Fuzzied optional messages should be considered untranslated

Outcome

Message groups with only optional messages do now get exported if other conditions are met.

Details

SubjectRepoBranchLines +/-
MessageGroupStats: Count optional messages with translationsmediawiki/extensions/Translatemaster+16 -3
Count optional messages towards translatedmediawiki/extensions/Translatemaster+103 -58
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nemo_bis created this task.Feb 27 2017, 10:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2017, 10:29 AM
Nemo_bis renamed this task from Consider translated optional messages to Consider translated optional messages towards meeting the export threshold.Feb 27 2017, 10:29 AM
Nemo_bis triaged this task as Low priority.
MarcoAurelio subscribed.Feb 27 2017, 10:50 AM
Nikerabbit updated the task description. (Show Details)Feb 28 2017, 8:57 AM
Nikerabbit moved this task from Backlog to Statistics on the MediaWiki-extensions-Translate board.
Nemo_bis updated the task description. (Show Details)Mar 30 2017, 4:08 PM
Nemo_bis mentioned this in T41068: Fuzzied optional messages should be considered untranslated.
Nikerabbit added a project: User-Nikerabbit.Nov 1 2018, 7:37 AM
Nikerabbit moved this task from Backlog to Translate twn on the User-Nikerabbit board.
Nikerabbit removed a project: User-Nikerabbit.Mar 25 2020, 12:20 PM
Nikerabbit raised the priority of this task from Low to High.Feb 4 2021, 9:09 AM
Nikerabbit added projects: Unplanned-Sprint-Work, Language-Team (Language-2021-January-March).
Nikerabbit subscribed.

Marking this as high priority now because with the export behavior changes, this causes deletion of files that should not be deleted.

gerritbot added a comment.Feb 4 2021, 12:13 PM

Change 661711 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Count optional messages towards translated

https://gerrit.wikimedia.org/r/661711

gerritbot added a project: Patch-For-Review.Feb 4 2021, 12:13 PM
gerritbot added a comment.Feb 4 2021, 3:20 PM

Change 661741 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Count optional messages with translations

https://gerrit.wikimedia.org/r/661741

gerritbot added a comment.Feb 4 2021, 4:02 PM

Change 661711 abandoned by Nikerabbit:
[mediawiki/extensions/Translate@master] Count optional messages towards translated

Reason:
In favor of a simpler patch

https://gerrit.wikimedia.org/r/661711

Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-January-March) board.Feb 4 2021, 4:06 PM
gerritbot added a comment.Feb 8 2021, 9:20 AM

Change 661741 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] MessageGroupStats: Count optional messages with translations

https://gerrit.wikimedia.org/r/661741

Nikerabbit moved this task from In Review to Recheck after deployment on the Language-Team (Language-2021-January-March) board.Feb 8 2021, 10:40 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).Feb 8 2021, 11:00 AM
Nikerabbit removed a project: Patch-For-Review.Feb 11 2021, 6:18 PM
Nikerabbit moved this task from Recheck after deployment to Done on the Language-Team (Language-2021-January-March) board.
Nikerabbit closed this task as Resolved.Feb 11 2021, 6:20 PM
Nikerabbit updated the task description. (Show Details)
Nikerabbit mentioned this in T139941: Allow deletion of languages during export that are under a threshold.Feb 16 2021, 8:25 AM
Nikerabbit mentioned this in T257205: Track translatewiki.net translation synchronization incidents.Feb 16 2021, 11:27 AM
Nikerabbit added a parent task: T257205: Track translatewiki.net translation synchronization incidents.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL